Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply comments from #7859 #1701

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Apply comments from #7859 #1701

merged 4 commits into from
Apr 19, 2022

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Apr 5, 2022

dotnet/dotnet-api-docs#7859 was merged before @gewarren's comments were addressed. This PR applies the same changes but makes them in the /// comments.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tom!

src/System.CommandLine/Parsing/Parser.cs Outdated Show resolved Hide resolved
/// </summary>
/// <param name="alias">The alias to add.</param>
/// <remarks>
/// You can add multiple aliases for a symbol.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there was some info added about what aliases could be used for. Not serious though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced that in the summary with a link on "alias" to the aliases section of the syntax article https://docs.microsoft.com/dotnet/standard/commandline/syntax#aliases

@jonsequitur
Copy link
Contributor

Thanks, @tdykstra!

@jonsequitur jonsequitur merged commit 70d72f0 into dotnet:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants