Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf improvements part 6: startup time #1654

Merged
merged 19 commits into from
Mar 1, 2022
Merged

Perf improvements part 6: startup time #1654

merged 19 commits into from
Mar 1, 2022

Commits on Feb 22, 2022

  1. extend ICommandHandler with synchronous Invoke method

    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    790646f View commit details
    Browse the repository at this point in the history

  2. don't build invocation chain if there is no middleware

    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    7b15e52 View commit details
    Browse the repository at this point in the history

  3. _executablePath.Value already uses Environment.GetCommandLineArgs()[0]

    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    e084081 View commit details
    Browse the repository at this point in the history

  4. Command.Validators: allocate when needed

    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    e950bf0 View commit details
    Browse the repository at this point in the history

  5. reduce and simplify ValidateCommandResult size to JIT less code in mo… 

    …st common scenarios
    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    465e150 View commit details
    Browse the repository at this point in the history

  6. reduce ParseResultVisitor.Stop size, saves 1 ms of JIT time for simpl… 

    …e scenarios
    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    4f7cc72 View commit details
    Browse the repository at this point in the history

  7. make Token a class again, so JIT does not need to compile specialized… 

    … methods for it. -3ms for startup!
    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    59b1941 View commit details
    Browse the repository at this point in the history

  8. refactor ParseDirectives to JIT less code when directives are not pro… 

    …vided (0.4 ms of JIT time)
    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0ed5532 View commit details
    Browse the repository at this point in the history

  9. refactor GetValueForHandlerParameter to JIT less code for most common… 

    … case
    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    fb76e42 View commit details
    Browse the repository at this point in the history

  10. remove static fields from StringExtensions (they need to be compiled … 

    …and initialized)
    @adamsitnik
    adamsitnik committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    bd44fb2 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. optimize getting Middleware by using Tuple (class) instead of ValueTu… 

    …ple (struct). -4 JIT compilaitons
    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    0a82102 View commit details
    Browse the repository at this point in the history

  2. use Nullable.GetUnderlyingType instead of custom implementation (and … 

    …compile less)
    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    3de63b1 View commit details
    Browse the repository at this point in the history

  3. don't use Lazy, -4 compilations

    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    2127b1e View commit details
    Browse the repository at this point in the history

  4. reduce the number of types derived from ArgumentConversionResult to r… 

    …educe the number of compilations and type loading
    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    1d7aff7 View commit details
    Browse the repository at this point in the history

  5. remove RootCommandNode to reduce the number of types

    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    692f045 View commit details
    Browse the repository at this point in the history

  6. remove another Lazy (the code it uses needed to be compiled the first… 

    … time ArgumentConverter was used, no matter if we wanted to create a list or not)
    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    54e26d4 View commit details
    Browse the repository at this point in the history

  7. add net6.0 to benchmarks project

    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    0d072bd View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into perfImprovements6 

    # Conflicts:
#	src/System.CommandLine/Binding/ArgumentConverter.cs
    @adamsitnik
    adamsitnik committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    511d6d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. address code review feedback

    @adamsitnik
    adamsitnik committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    5f475cb View commit details
    Browse the repository at this point in the history