This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Update codeOptimization targets #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @weshaggard @adiaaida @maririos |
|
LGTM |
weshaggard
reviewed
Oct 26, 2018
| @@ -84,7 +85,7 @@ | |||
|
|
|||
| <!-- We need the OptimizationData package in order to be able to optimize the assembly --> | |||
| <Target Name="RestoreOptimizationDataPackage" | |||
| BeforeTargets="Sync" | |||
| BeforeTargets="Restore" | |||
There was a problem hiding this comment.
Please just remove this we should avoid this "magic" hook-up because we will easily break it if we don't look for it.
There was a problem hiding this comment.
How would you suggest these targets get called?
There was a problem hiding this comment.
Actually you should be careful about changing this at all. If there are other repo's still hooking this up with Sync either changing it or removing will break those.
There was a problem hiding this comment.
How would you suggest these targets get called?
It should be explicitly pulled in like I did in dotnet/corefx#33076.
This work allows us to specify the IBC data package that we will pull down depending on whether we are doing application for Linux or Windows.
DrewScoggins
force-pushed
the
UpdateOptTarget
branch
from
3a0adf9 to
d6f40ea
Compare
|
I decided to just remove the dependency on Sync, since we are calling this explicitly . @weshaggard |
weshaggard
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has two parts to it. The first is fixing a breaking change
that was introduced with the Arcade work in CoreFX. The restore target
that we had for brining down the IBC data was relying on the sync
target which was removed. It now follows the restore target.
The second piece is work that allows us to specify the IBC data package
that we will pull down depending on whether we are doin application for
Linux or Windows.