Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Test on CentOS 7, not RedHat 7 #58561

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[release/6.0] Test on CentOS 7, not RedHat 7 #58561

merged 1 commit into from
Nov 5, 2024

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 22, 2024

[release/6.0] Test on CentOS 7, not RedHat 7

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Fixes part of dotnet/dnceng#4298

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 6.0.x milestone Oct 22, 2024
@dougbu
[release/6.0] Test on CentOS 7, not RedHat 7
97577c8 
- dotnet/dnceng#4298 part II/II
  - contributes to dotnet/dnceng#3189
- use Docker container for CentOS, mimicking dotnet/runtime#105063
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Oct 22, 2024
@dougbu dougbu requested a review from a team October 23, 2024 00:52
@dougbu dougbu marked this pull request as ready for review October 23, 2024 00:52
@dougbu
Copy link
Member Author

dougbu commented Oct 23, 2024

hi @halter73, @BrennanConroy, @wtgodbe, and other @dotnet/aspnet-build members. I'm just visiting 😁

oh @Tratcher is still in the CODEOWNERS file. nice and hi to you too

@dougbu
Copy link
Member Author

dougbu commented Oct 23, 2024

/ping

wtgodbe
wtgodbe approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but are we planning on shipping another 6.0 release?

@dougbu
Copy link
Member Author

dougbu commented Oct 28, 2024

on hold until release/6.0 branch opens again

This was referenced Oct 28, 2024
Closed
Closed
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 5, 2024
@dougbu
Copy link
Member Author

dougbu commented Nov 5, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Member Author

dougbu commented Nov 5, 2024

/ping @wtgodbe for final squish 'n merge once build goes through 😁

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 5, 2024
@wtgodbe wtgodbe merged commit e185938 into dotnet:release/6.0 Nov 5, 2024
23 checks passed
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.36 Nov 5, 2024
@dougbu dougbu deleted the dougbu/no.redhat.4298 branch November 5, 2024 21:28
@dougbu
Copy link
Member Author

dougbu commented Nov 5, 2024

thanx @wtgodbe❗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
6.0.36
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe