Merge RC2 changes into 9.0 #58296
Merged
Merge RC2 changes into 9.0 #58296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't complete the `PipeWriter` when it still might be used by Application code. ---- #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request addresses a bug in the HTTP/3 implementation related to memory management and pipe completion. - `Http3RequestTests.cs`: Added a new test to ensure memory is preserved when the connection closes. - `Http3OutputProducer.cs`: Refactored `Dispose` method and added `Complete` method to properly handle pipe completion. - `DiagnosticMemoryPool.cs`: Added `ContainsMemory` method to check if memory is still rented from the pool. - `Http3Stream.cs`: Ensured `Complete` is called on `_http3Output` when the stream is closed. - `Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj`: Added `InternalsVisibleTo` for `Interop.FunctionalTests`.
…dnceng/internal/dotnet-efcore, dnceng/internal/dotnet-runtime This pull request updates the following dependencies [marker]: <> (Begin:8dae0f3c-a39b-44b8-9786-989490256245) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - **Subscription**: 8dae0f3c-a39b-44b8-9786-989490256245 - **Build**: 20240917.3 - **Date Produced**: September 17, 2024 9:27:09 PM UTC - **Commit**: 10507ab37be167432fe16d2dc71469cc193e463d - **Branch**: refs/heads/internal/release/9.0-rc2 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Bcl.AsyncInterfaces**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Bcl.TimeProvider**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Caching.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Caching.Memory**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.Binder**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.CommandLine**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.EnvironmentVariables**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.FileExtensions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.Ini**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.Json**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.UserSecrets**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Configuration.Xml**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.DependencyInjection**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.DependencyInjection.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.DependencyModel**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Diagnostics**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Diagnostics.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.FileProviders.Abstractions**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.FileProviders.Composite**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.FileProviders.Physical**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.FileSystemGlobbing**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.HostFactoryResolver.Sources**: [from 9.0.0-rc.2.24463.7 to 9.0.0-rc.2.24467.3][1] - **Microsoft.Extensions.Hosting**: [fr...
…dnceng/internal/dotnet-efcore, dnceng/internal/dotnet-runtime This pull request updates the following dependencies [marker]: <> (Begin:8dae0f3c-a39b-44b8-9786-989490256245) ## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime - **Subscription**: 8dae0f3c-a39b-44b8-9786-989490256245 - **Build**: 20240923.5 - **Date Produced**: September 24, 2024 1:50:56 AM UTC - **Commit**: 990ebf52fc408ca45929fd176d2740675a67fab8 - **Branch**: refs/heads/internal/release/9.0-rc2 [DependencyUpdate]: <> (Begin) - **Updates**: - **Microsoft.Bcl.AsyncInterfaces**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Bcl.TimeProvider**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Caching.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Caching.Memory**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.Binder**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.CommandLine**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.EnvironmentVariables**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.FileExtensions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.Ini**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.Json**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.UserSecrets**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Configuration.Xml**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.DependencyInjection**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.DependencyInjection.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.DependencyModel**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Diagnostics**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Diagnostics.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.FileProviders.Abstractions**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.FileProviders.Composite**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.FileProviders.Physical**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.FileSystemGlobbing**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.HostFactoryResolver.Sources**: [from 9.0.0-rc.2.24471.4 to 9.0.0-rc.2.24473.5][1] - **Microsoft.Extensions.Hosting**: [fr...
wtgodbe
requested review from
halter73,
BrennanConroy,
JamesNK,
mgravell and
a team
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
BrennanConroy
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.