Add support for Chromium Snap cert trust #57256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought this already worked, but it turns out it behaves differently depending on how you launch it. When it is launched as a snap (vs from the command line), it can only access things in its own folder, so it looks in a different NSS DB for trusted certs. Fixing this is as simple as adding one more well-known location to the list.
dotnet-issue-labeler
bot
added
the
area-commandlinetools
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/10327407839 |
10 tasks
adityamandaleeka
approved these changes
Aug 10, 2024
|
Validated locally. |
amcasey
commented
Aug 10, 2024
| @@ -476,6 +476,11 @@ private static string GetChromiumNssDb(string homeDirectory) | |||
| return Path.Combine(homeDirectory, ".pki", "nssdb"); | |||
| } | |||
|
|
|||
| private static string GetChromiumSnapNssDb(string homeDirectory) | |||
| { | |||
| return Path.Combine(homeDirectory, "snap", "chromium", "current", ".pki", "nssdb"); | |||
There was a problem hiding this comment.
current is a symlink to a folder named for the version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this already worked, but it turns out it behaves differently depending on how you launch it. When it is launched as a snap (vs from the command line), it can only access things in its own folder, so it looks in a different NSS DB for trusted certs. Fixing this is as simple as adding one more well-known location to the list.