[H/3] Fix code passed into QuicConnection.CloseAsync and QuicStream.Abort #55282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManickaP
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
amcasey
approved these changes
Apr 22, 2024
src/Servers/Kestrel/Transport.Quic/src/Internal/QuicConnectionContext.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs
Outdated
Show resolved
Hide resolved
|
My new check is failing CI. The test fails for me locally, but not until after the log message check succeeds, so I'm not sure why that's happening. I'll investigate. Edit: it was flaky before my change. |
|
The windows failure is known CI flakiness |
|
Okay, looking more closely, the failure I'm seeing here is the same one I'm seeing locally and isn't related to the logging check. I think the test is flaky in that it won't reliably cause the connection to be closed on the server side. |
amcasey
reviewed
Apr 25, 2024
src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Apr 26, 2024
src/Servers/Kestrel/Transport.Quic/src/Internal/QuicStreamContext.cs
Outdated
Show resolved
Hide resolved
I worked backwards from calls to `QuicConnection.CloseAsync` and `QuicStream.Abort`. TODO: Update tests
|
I believe the PR is ready to go. |
amcasey
reviewed
May 2, 2024
src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs
Outdated
Show resolved
Hide resolved
|
Ah, it was auto-merge from the previous design and my sign-off counts because it's technically Mana's PR. Well, shout if you don't like the exceptions @halter73. |
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the code passed into
QuicConnection.CloseAsyncandQuicStream.Abortwhich was by default -1. Quic supports only error codes up to 62 bits non-negative integer values: https://www.rfc-editor.org/rfc/rfc9000.html#integer-encoding.Also added test which crashes the process (if running with DEBUG build of MsQuic) before this change and runs to completion afterwards.
Let me know if you want me to shuffle the code around, I'm not much familiar with the structure of your code base.
cc @amcasey
Fixes #55196
Also this will be followed up in S.N.Quic with some checks (dotnet/runtime#101385).