Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass dotnetEfVersion in Helix test runner #52104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 15, 2023

Port of a test fix from 7.0. Without this, the Helix Test Runner downloads the latest stable dotnet-ef from nuget.org, so once 10.0 ships, 9.0 tests using dotnet-ef will fail.

@wtgodbe wtgodbe requested a review from a team as a code owner November 15, 2023 22:37
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2023
@wtgodbe wtgodbe enabled auto-merge (squash) November 15, 2023 23:48
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 16, 2023

Weird, it looks like the tool .nuspec's are winding up in the Correlation payload, not the .nupkg's:

2023-11-16T18:30:12.5792666Z Displaying directory contents for C:\h\w\B82909DB\p:
2023-11-16T18:30:12.5793039Z .signature.p7s
2023-11-16T18:30:12.5793085Z dotnet-dump.nuspec
2023-11-16T18:30:12.5793112Z dotnet-ef.nuspec
2023-11-16T18:30:12.5793138Z dotnet-serve.nuspec
2023-11-16T18:30:12.5793164Z Icon.png
2023-11-16T18:30:12.5793189Z README.md
2023-11-16T18:30:12.5793214Z test-configuration.json
2023-11-16T18:30:12.5793238Z [Content_Types].xml
2023-11-16T18:30:12.5793719Z dotnet-cli
2023-11-16T18:30:12.5793768Z HelixTestRunner
2023-11-16T18:30:12.5793794Z package
2023-11-16T18:30:12.5793817Z reporter
2023-11-16T18:30:12.5793842Z scripts
2023-11-16T18:30:12.5793866Z tools
2023-11-16T18:30:12.5793889Z _rels

Despite us including the .nupkg's in the correlation payload itemgroup:

<HelixCorrelationPayload Include="$(NUGET_PACKAGES)\dotnet-dump\$(DotnetDumpVersion)\dotnet-dump.$(DotnetDumpVersion).nupkg" />
<HelixCorrelationPayload Include="$(NUGET_PACKAGES)\dotnet-ef\$(DotnetEfVersion)\dotnet-ef.$(DotnetEfVersion).nupkg" />
<HelixCorrelationPayload Include="$(NUGET_PACKAGES)\dotnet-serve\$(DotnetServeVersion)\dotnet-serve.$(DotnetServeVersion).nupkg" />

Will grab a binlog and take a look

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 25, 2023
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment Feb 13, 2024
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants