Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update dependencies from dotnet/source-build-externals #50397

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 29, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-externals

  • Subscription: 3dc3d394-290e-43ab-8e2f-08db9e435944
  • Build: 20230829.1
  • Date Produced: August 29, 2023 1:28:01 PM UTC
  • Commit: 0603839a51f5e18b89c60a3690aff5e81fa666ca
  • Branch: refs/heads/main

…nals build 20230829.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23429.1
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners August 29, 2023 13:58
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 29, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost
Copy link

ghost commented Aug 29, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@mthalman
Copy link
Member

I've updated the Newtonsoft.Json version to resolve the source-build prebuilts. .NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.

Related to dotnet/source-build-externals#195

@mthalman mthalman requested a review from MichaelSimons August 29, 2023 14:24
eng/Versions.props Show resolved Hide resolved
@dotnet-maestro dotnet-maestro bot merged commit 86ae2d1 into release/8.0 Aug 29, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-release/8.0-28de02dd-dfe9-40a4-a5b4-a500484d8f23 branch August 29, 2023 16:56
@ghost ghost added this to the 8.0-rc2 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants