Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make security project ref #4618

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Make security project ref #4618

merged 1 commit into from
Dec 14, 2018

Conversation

jkotalik
Copy link
Contributor

No description provided.

@jkotalik jkotalik force-pushed the jkotalik/moveSecurityToProjectRef branch from 0a02108 to da3ba41 Compare December 12, 2018 22:02
natemcmaster
natemcmaster suggested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start. I added a few comments about little things that can change in the project file, and I pushed a commit to your PR to trim some stale content from the README in src/Security

One thing you should for sure revert is the removal of the git submodules. :) Still required for now.

cc @Tratcher - you may be interested in viewing the source code layout.

src/Mvc/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Microsoft.AspNetCore.Mvc.ViewFeatures.csproj Outdated Show resolved Hide resolved
...est/Microsoft.AspNetCore.Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj Outdated Show resolved Hide resolved
src/Security/Authentication.Cookies/src/Microsoft.AspNetCore.Authentication.Cookies.csproj Outdated Show resolved Hide resolved
src/Security/Authentication.JwtBearer/src/Microsoft.AspNetCore.Authentication.JwtBearer.csproj Outdated Show resolved Hide resolved
src/Security/Authentication.WsFederation/samples/WsFedSample/WsFedSample.csproj Outdated Show resolved Hide resolved
src/Security/Authentication/src/Microsoft.AspNetCore.Authentication.csproj Outdated Show resolved Hide resolved
src/Security/Authorization.Policy/src/Microsoft.AspNetCore.Authorization.Policy.csproj Outdated Show resolved Hide resolved
src/Security/CookiePolicy/test/Microsoft.AspNetCore.CookiePolicy.Test.csproj Outdated Show resolved Hide resolved
@Tratcher
Copy link
Member

The layout's a little odd, especially for the AuthN samples and tests that pull in stuff from other folders. How about:

  • Authentication/
    • src
      • Core
      • Cookies
      • Facebook
      • Google
      • JwtBearer
      • ...
    • samples/SocialSample
    • tests
  • Authorization/
    • src
      • Core (src, test)
      • Policy
  • CookiePolicy
  • Interop

Also, the src folder can be flattened when it's the only folder for a given package. E.g. Authenticaiton/Facebook/Microsoft.AspnetCore.Authentication.Facebook.csproj

@JunTaoLuo
Copy link
Contributor

I'll take over this PR since I need it for Identity.

@JunTaoLuo JunTaoLuo self-assigned this Dec 14, 2018
@Tratcher
Copy link
Member

Updated after talking to @natemcmaster

  • Authentication/
    • Core
    • Cookies
    • Facebook
    • Google
    • JwtBearer
    • ...
    • samples/SocialSample
    • tests
  • Authorization/
    • Core
    • Policy
  • CookiePolicy
  • Interop

And don't worry about flattening the solo src dirs, it sounds like each of these will get paired with a ref dir.

@JunTaoLuo JunTaoLuo force-pushed the jkotalik/moveSecurityToProjectRef branch from 99bd440 to 069f80d Compare December 14, 2018 19:59
@JunTaoLuo JunTaoLuo force-pushed the jkotalik/moveSecurityToProjectRef branch from 6e19bdd to 94f75f5 Compare December 14, 2018 20:52
@JunTaoLuo
Copy link
Contributor

Updated

@JunTaoLuo JunTaoLuo merged commit 68f0aff into release/2.1 Dec 14, 2018
@JunTaoLuo JunTaoLuo deleted the jkotalik/moveSecurityToProjectRef branch December 14, 2018 22:49
@natemcmaster natemcmaster mentioned this pull request Dec 17, 2018
Merged
@JunTaoLuo JunTaoLuo mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@Tratcher Tratcher Tratcher approved these changes

Assignees

@JunTaoLuo JunTaoLuo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotalik @Tratcher @JunTaoLuo @natemcmaster