-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump .NET SDK again #38506
Bump .NET SDK again #38506
Conversation
dougbu
commented
Nov 18, 2021
- remove Microsoft.NET.Test.Sdk version override
- new vstest.console.dll in the .NET SDK is again compatible w/ older testhost.dll in the Test SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR didn't test on Arm64 (Windows or Linux). I should instead of just used the branch in a run of our But, looking at the consistent failures in this trial, I doubt that's worthwhile. The newer SDK seems to introduce a bug in
@dsplaisted who should we contact about that problem❔ @MarcoRossignoli and I were just trying to see if the new test bits in the .NET SDK were compatible w/ the 16.x Test SDK. Hit this first |
Where is that error message coming from and what's the stack trace? Looking at the CI failures currently, I only see a different message:
|
@dsplaisted plz look near the top of the console log, where the test infrastructure executes
I was wrong in thinking the problem was specific to Linux and macOS. The above commands are from a Windows console log for the failing work item. |
@sfoslund Can you take a look at this tool install issue? (Assuming you own dotnet tools now, which I think is the case). It looks like it doesn't like |
Doesn't like |
@joeloff owns tools now, but I have bandwidth to take a look if he needs. Although it looks like he's already fixing a similar issue: dotnet/sdk#22684, @joeloff is this the same bug or a different one? |
This looks similar to what I'm fixing in 6.0.2xx dotnet/sdk#22684 |
- remove Microsoft.NET.Test.Sdk version override - new vstest.console.dll in the .NET SDK is again compatible w/ older testhost.dll in the Test SDK
This should have the fix we need: dotnet/installer#12716 |
5264a32
to
20dec36
Compare
Trying it all again w/ the 7.0.100-alpha.1.21574.8 SDK (which includes @joeloff's fix) |
Is it dotnet/installer that populates https://dotnetbuilds.azureedge.net❔
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Getting further from an actual test; likely need dotnet/sdk#22668 to merge before dotnet/installer#12716 will work |
If we get a usable SDK / installer build containing @MarcoRossignoli's fix, this branch is also available at https://github.com/dotnet/aspnetcore/tree/dougbu/remove.override i.e. there's no need for anyone else to update my fork. Not creating a new PR using the non-fork branch because work here remains blocked. |
Whoops, updated this too early. Next installer build should have the fix we need: https://dev.azure.com/dnceng/internal/_build/results?buildId=1499097&view=results |