Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump .NET SDK again #38506

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Bump .NET SDK again #38506

merged 3 commits into from
Dec 6, 2021

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 18, 2021

  • remove Microsoft.NET.Test.Sdk version override
  • new vstest.console.dll in the .NET SDK is again compatible w/ older testhost.dll in the Test SDK

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 18, 2021
Copy link
Member

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougbu
Copy link
Member Author

dougbu commented Nov 18, 2021

This PR didn't test on Arm64 (Windows or Linux). I should instead of just used the branch in a run of our aspnetcore-helix-matrix pipeline.

But, looking at the consistent failures in this trial, I doubt that's worthwhile. The newer SDK seems to introduce a bug in dotnet tool and it's not able to install dotnet-ef at version 7.0.0-alpha.1.21568.2:

Unhandled exception: System.ArgumentException: Version string portion was too short or too long. (Parameter 'input')

@dsplaisted who should we contact about that problem❔ @MarcoRossignoli and I were just trying to see if the new test bits in the .NET SDK were compatible w/ the 16.x Test SDK. Hit this first ☹️

@dsplaisted
Copy link
Member

Where is that error message coming from and what's the stack trace? Looking at the CI failures currently, I only see a different message:

System.ComponentModel.Win32Exception : An error occurred trying to start process 'dotnet-ef' with working directory 'C:hwA35C090EwAF8C093BeTemplatesBaseFolderAspNet.mlxmrxruasmServer'. The system cannot find the file specified.

@dougbu
Copy link
Member Author

dougbu commented Nov 19, 2021

@dsplaisted plz look near the top of the console log, where the test infrastructure executes dotnet tool install dotnet-ef .... The stack trace seems consistent across platforms and affects both 'C:\h\w\A35C090E\p\dotnet-cli/dotnet tool install dotnet-dump --tool-path C:\h\w\A35C090E\w\AF8C093B\e --version 5.0.0-*' and 'C:\h\w\A35C090E\p\dotnet-cli/dotnet tool install dotnet-ef --version 7.0.0-alpha.1.21568.2 --tool-path C:\h\w\A35C090E\w\AF8C093B\e' completed with exit code '1'.

Unhandled exception: System.ArgumentException: Version string portion was too short or too long. (Parameter 'input')
   at System.Version.ParseVersion(ReadOnlySpan`1 input, Boolean throwOnFailure)
   at System.Version.Parse(String input)
   at System.Version..ctor(String version)
   at Microsoft.DotNet.Tools.Tool.Install.ToolInstallGlobalOrToolPathCommand.<>c.<Execute>b__17_1(NuGetFramework f)
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Enumerable.MaxBy[TSource,TKey](IEnumerable`1 source, Func`2 keySelector, IComparer`1 comparer)
   at Microsoft.DotNet.Tools.Tool.Install.ToolInstallGlobalOrToolPathCommand.Execute()

I was wrong in thinking the problem was specific to Linux and macOS. The above commands are from a Windows console log for the failing work item.

@dsplaisted
Copy link
Member

@sfoslund Can you take a look at this tool install issue? (Assuming you own dotnet tools now, which I think is the case). It looks like it doesn't like --version 5.0.0-*, which I guess used to work.

@dougbu
Copy link
Member Author

dougbu commented Nov 19, 2021

It looks like it doesn't like --version 5.0.0-*, which I guess used to work.

Doesn't like --version 7.0.0-alpha.1.21568.2 much either.

@sfoslund
Copy link
Member

Can you take a look at this tool install issue? (Assuming you own dotnet tools now, which I think is the case). It looks like it doesn't like --version 5.0.0-*, which I guess used to work.

@joeloff owns tools now, but I have bandwidth to take a look if he needs. Although it looks like he's already fixing a similar issue: dotnet/sdk#22684, @joeloff is this the same bug or a different one?

@joeloff
Copy link
Member

joeloff commented Nov 19, 2021

This looks similar to what I'm fixing in 6.0.2xx dotnet/sdk#22684

- remove Microsoft.NET.Test.Sdk version override
- new vstest.console.dll in the .NET SDK is again compatible w/ older testhost.dll in the Test SDK
@wtgodbe
Copy link
Member

wtgodbe commented Nov 24, 2021

This should have the fix we need: dotnet/installer#12716

@dougbu dougbu force-pushed the dougbu/remove.override branch from 5264a32 to 20dec36 Compare November 24, 2021 21:40
@dougbu
Copy link
Member Author

dougbu commented Nov 24, 2021

Trying it all again w/ the 7.0.100-alpha.1.21574.8 SDK (which includes @joeloff's fix)

@dougbu
Copy link
Member Author

dougbu commented Nov 24, 2021

Is it dotnet/installer that populates https://dotnetbuilds.azureedge.net

dotnet-install: Downloading primary link https://dotnetbuilds.azureedge.net/public/Sdk/7.0.100-alpha.1.21574.8/dotnet-sdk-7.0.100-alpha.1.21574.8-linux-x64.tar.gz
curl: (22) The requested URL returned error: 404 

@dougbu
Copy link
Member Author

dougbu commented Nov 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dougbu
Copy link
Member Author

dougbu commented Nov 30, 2021

Getting further from an actual test; likely need dotnet/sdk#22668 to merge before dotnet/installer#12716 will work ☹️

@dougbu
Copy link
Member Author

dougbu commented Dec 2, 2021

If we get a usable SDK / installer build containing @MarcoRossignoli's fix, this branch is also available at https://github.com/dotnet/aspnetcore/tree/dougbu/remove.override i.e. there's no need for anyone else to update my fork. Not creating a new PR using the non-fork branch because work here remains blocked.

@wtgodbe
Copy link
Member

wtgodbe commented Dec 6, 2021

Whoops, updated this too early. Next installer build should have the fix we need: https://dev.azure.com/dnceng/internal/_build/results?buildId=1499097&view=results

@wtgodbe wtgodbe marked this pull request as ready for review December 6, 2021 19:27
@wtgodbe wtgodbe requested a review from a team as a code owner December 6, 2021 19:27
@wtgodbe wtgodbe enabled auto-merge (squash) December 6, 2021 19:27
@wtgodbe wtgodbe merged commit fc4e391 into dotnet:main Dec 6, 2021
@ghost ghost added this to the 7.0-preview1 milestone Dec 6, 2021
@dougbu dougbu deleted the dougbu/remove.override branch December 6, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants