Update Components to use LoggerMessage #35585
Conversation
ghost
added
the
|
Does blazor have any tests that very logs? |
Probably not? I think there are a few that verify error cases, but we rarely verify the vast majority of log messages. |
| [LoggerMessage(202, LogLevel.Debug, "Invoking instance method '{MethodIdentifier}' on instance '{DotNetObjectId}' with callback id '{CallId}'.", EventName = "BeginInvokeDotNet")] | ||
| private static partial void BeginInvokeDotNet(ILogger logger, string methodIdentifier, long dotNetObjectId, string callId); | ||
|
|
||
| [LoggerMessage(217, LogLevel.Debug, "Invoking static method with identifier '{MethodIdentifier}' on assembly '{Assembly}' with callback id '{CallId}'.", EventName = "BeginInvokeDotNetStatic")] |
There was a problem hiding this comment.
Breaking change this previously re-used eventId - 202.
| [LoggerMessage(203, LogLevel.Debug, "Failed to invoke instance method '{MethodIdentifier}' on instance '{DotNetObjectId}' with callback id '{CallId}'.", EventName = "BeginInvokeDotNetFailed")] | ||
| private static partial void BeginInvokeDotNetFailed(ILogger logger, string methodIdentifier, long dotNetObjectId, string callId, Exception exception); | ||
|
|
||
| [LoggerMessage(218, LogLevel.Debug, "Failed to invoke static method with identifier '{MethodIdentifier}' on assembly '{Assembly}' with callback id '{CallId}'.", EventName = "BeginInvokeDotNetFailed")] |
There was a problem hiding this comment.
Breaking change this previously re-used eventId - 203
| [LoggerMessage(204, LogLevel.Debug, "There was an error invoking 'Microsoft.JSInterop.DotNetDispatcher.EndInvoke'.", EventName = "EndInvokeDispatchException")] | ||
| public static partial void EndInvokeDispatchException(ILogger logger, Exception ex); | ||
|
|
||
| [LoggerMessage(205, LogLevel.Debug, "The JS interop call with callback id '{AsyncCall}' with arguments {Arguments}.", EventName = "EndInvokeJSFailed")] |
There was a problem hiding this comment.
This log statement changed. It used to previously say:
"The JS interop call with callback id '{AsyncCall}' failed with error '{Error}'."
but Error is not value that appears in the code. The calling code does say it should be safe to include the Arguments: in the log message, so this was probably a wrong log statement all along
pranavkm
force-pushed
the
prkrishn/components-loggermessage
branch
from
832ea98 to
fc20c11
Compare
No description provided.