Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend checking the logs for errors #33055 #33235

Closed
wants to merge 1 commit into from

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Jun 2, 2021

Fixes #33055

The error page says to enable development mode if you want to see the error, but it does not say what to do in production. In both environments we should recommend checking the server logs before enabling development mode.

Draft until:

  • We confirm we like the text (@danroth27?)
  • We get an aka link for the docs (@danroth27?)
  • I copy it to the other templates

@Tratcher Tratcher requested a review from danroth27 June 2, 2021 22:24
@Tratcher Tratcher self-assigned this Jun 2, 2021
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 2, 2021
@Tratcher Tratcher added this to the 6.0-preview6 milestone Jun 2, 2021
@danroth27
Copy link
Member

Production error pages are often viewed by users of the site, not the site admin. Normal users won't know about Development environments or server logs. Isn't it more typical to have text that says something has gone wrong with the site and that they need to contact the site admin for assistance?

@Tratcher
Copy link
Member Author

Tratcher commented Jun 2, 2021

We could certainly lead with "contact your site administrator", but I still think we need some comments targeted at the admin "if you are the site administrator...", those are the ones that see the page and contact us for help.

@danroth27
Copy link
Member

I don't think the site admin is really the audience for this production error page. The main audience is the end user. Exposing site admin concerns to end users doesn't seem like a good user experience for a website. I think we should remove the existing Development mode content and replace it with something like "Please contact the site administrator for assistance." Leave the request ID, so that the user can share that with the admin.

@Tratcher
Copy link
Member Author

Tratcher commented Jun 3, 2021

See this example issue: AzureAD/microsoft-identity-web#1213
(There's a secondary issue there where enabling Development didn't help).

We get reports like this from developers that break their site on deployment and don't know how to investigate it. They tell us they want more information on this page, not less. Compare to the ANCM error page that gives diagnostic suggestions:
https://weblog.west-wind.com/posts/2020/Jan/14/ASPNET-Core-IIS-InProcess-Hosting-Issues-in-NET-Core-31

@Tratcher Tratcher closed this Jul 15, 2021
@Tratcher Tratcher deleted the tratcher/errorlogs branch July 15, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The template error page should recommend checking the server logs.
2 participants