Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running template tests on azdo job (already helix-ified) #32985

Merged
merged 2 commits into from
May 25, 2021
Merged

Stop running template tests on azdo job (already helix-ified) #32985

merged 2 commits into from
May 25, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented May 24, 2021

Fixes #30756

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 24, 2021
@dougbu dougbu mentioned this pull request May 25, 2021
Closed
@HaoK HaoK marked this pull request as ready for review May 25, 2021 06:16
@HaoK HaoK requested a review from a team as a code owner May 25, 2021 06:16
@HaoK HaoK merged commit 7a842b7 into main May 25, 2021
@HaoK HaoK deleted the haok/runonce branch May 25, 2021 16:44
@ghost ghost added this to the 6.0-preview6 milestone May 25, 2021
BrennanConroy
BrennanConroy reviewed May 25, 2021
View reviewed changes
.azure/pipelines/quarantined-pr.yml
@@ -86,9 +86,6 @@ jobs:
steps:
- powershell: "& ./eng/build.ps1 -CI -nobl -all -pack -NoBuildJava"
displayName: Build
# The templates part can be removed when the Blazor Templates run on Helix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the Mac and Linux legs weren't given the same treatment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I didn't even realize we ran those on mac/linux, I will remove those as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33002

captainsafia added a commit that referenced this pull request Jul 11, 2021
@captainsafia
Revert "Stop running template tests on azdo job (already helix-ified) (…
62fbc87 
…#32985)"

This reverts commit 7a842b7.
dotnet-maestro bot added a commit that referenced this pull request Jul 12, 2021
@dotnet-maestro
[main] Update dependencies from dotnet/efcore dotnet/runtime (#34033)
6c396e7 
[main] Update dependencies from dotnet/efcore dotnet/runtime


 - Workaround duplicate logging source generator

 - Merge branch 'main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720

 - Fix CS8795

https://dev.azure.com/dnceng/public/_build/results?buildId=1222936&view=logs&jobId=b5df7d42-2bda-5dee-96bd-1838a4f7499c&j=b5df7d42-2bda-5dee-96bd-1838a4f7499c&t=c1ffdaa9-e800-5fe8-052c-643f2e9f52ff

 - Update Wasm.Performance.TestApp.csproj

 - Fix skipEnabledCheck

 - Merge branch 'main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720

 - Update Workarounds.targets

 - Revert "Fix CS8795"

This reverts commit a2ec9d6.

 - Revert "Convert HealthChecks logging to use new Logging Source Generator (#32414)"

This reverts commit 1dd00f4.

 - Utilize class level SkipEnabledCheckLogOptions

 - React to MvcCoreLoggerExtensions feedback

 - Merge remote-tracking branch 'origin/main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720

 - React to nullability changes in TypeConverter

 - Merge branch 'main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720

 - React to new analyzer warnings

 - Revert "Revert "Convert HealthChecks logging to use new Logging Source Generator (#32414)""

This reverts commit 5d6e21e.

 - Update src/Http/Routing/src/Matching/DfaMatcher.cs

Co-authored-by: Eric Erhardt <[email protected]>

 - Update exception caught in HTTP2 tests

 - Merge branch 'main' of https://github.com/dotnet/aspnetcore into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720

 - Revert "Remove usings from templates implicitly added by the SDK (#34219)"

This reverts commit d8bba72.

 - Fix up exceptions for HTTP2 tests

 - Revert "Revert "Remove usings from templates implicitly added by the SDK (#34219)""

This reverts commit cce1bd7.

 - Bump up SDK to bring in usings changes

 - Try running template tests on non-Helix

 - Update ci.yml

 - Try disabling template tests on Helix

 - Revert "Stop running template tests on azdo job (already helix-ified) (#32985)"

This reverts commit 7a842b7.

 - Don't build Helix payload for template tests

 - Temporarily skip FrameworkListListsContainsCorrectPaths

 - Use dotnet test for test discovery

 - Revert "Use dotnet test for test discovery"

This reverts commit f5cecb2.

 - Try skipping listing tests list in helix

 - Revert "Try disabling template tests on Helix"

This reverts commit 2136f31.

 - Remove generic type from test method

 - Removed another generic from the test method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy left review comments

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-preview6
Development

Successfully merging this pull request may close these issues.

Template tests are run twice azdo + helix
3 participants
@HaoK @BrennanConroy @wtgodbe