Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder HealthCheck status logging #32524

Closed
wants to merge 4 commits into from
Closed

Reorder HealthCheck status logging #32524

wants to merge 4 commits into from

Conversation

mettelephant
Copy link

  • [ X] You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • [X ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Reorder HealthChecks logging to match previous change

PR Description
A previous PR #26575 updated the format of the health check logs but not the parameters. This should update those to match.

Addresses #32523

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 9, 2021
@mkArtakMSFT mkArtakMSFT added the area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) label May 10, 2021
@mkArtakMSFT mkArtakMSFT requested a review from javiercn May 10, 2021 15:04
@mkArtakMSFT
Copy link
Member

Thanks for your PR. @javiercn can you please take a look at this? Thanks!

javiercn
javiercn approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

Thanks for the contribution!

@BrennanConroy
Copy link
Member

Looks like this ended up getting resolved as part of a logging refactor in #32414

Sorry this wasn't merged @mettelephant, we do appreciate the change though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT left review comments

@FirstAfterGod2501 FirstAfterGod2501 FirstAfterGod2501 approved these changes

@javiercn javiercn javiercn approved these changes

Assignees

@javiercn javiercn

Labels
area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mettelephant @mkArtakMSFT @BrennanConroy @javiercn @FirstAfterGod2501