Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from RuntimeInformation.IsOSPlatform(XYZ) to OperatingSystem.IsXYZ() #28233

Merged
merged 9 commits into from
Dec 2, 2020
Merged

Switching from RuntimeInformation.IsOSPlatform(XYZ) to OperatingSystem.IsXYZ() #28233

merged 9 commits into from
Dec 2, 2020

Conversation

stefannikolei
Copy link
Contributor

@stefannikolei stefannikolei commented Nov 29, 2020 •
edited
Loading

#24653

I changed it in many places. Some testprojects are still left.

@ghost ghost added the area-hosting label Nov 29, 2020
@stefannikolei stefannikolei changed the title Changed Hosting Switching from RuntimeInformation.IsOSPlatform(XYZ) to OperatingSystem.IsXYZ() Nov 29, 2020
@stefannikolei stefannikolei marked this pull request as ready for review November 29, 2020 11:02
pranavkm
pranavkm approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the PR

@pranavkm pranavkm added this to the 6.0-preview1 milestone Dec 1, 2020
@mkArtakMSFT mkArtakMSFT added the community-contribution Indicates that the PR has been added by a community member label Dec 2, 2020
@mkArtakMSFT mkArtakMSFT merged commit 7ce071b into dotnet:master Dec 2, 2020
@mkArtakMSFT
Copy link
Member

Thanks for your contribution, @stefannikolei

@eerhardt eerhardt mentioned this pull request Feb 11, 2021
Closed
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-hosting Includes Hosting community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
6.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@stefannikolei @mkArtakMSFT @pranavkm @amcasey