Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links in "new issue" flow to other related repos #21841

Merged
merged 5 commits into from
May 17, 2020
Merged

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented May 14, 2020

This .yml adds quick links to other repos below the existing issue template buttons in your new issue flow.

For an example of what this will look like, see https://github.com/danmosemsft/runtime/issues/new/choose (the white buttons)

Note that the flow takes you to the other repos issue template selector (if any) otherwise to their new issue form directly.

We are adding this in dotnet/runtime (dotnet/runtime#36431). Reasoning: it's sometimes confusing which is the correct repo to open an issue in. The goal here is to make it easier to open an issue in the correct repo first time so we need to move fewer issues and they more quickly get attention from the right people.

@danmoseley danmoseley requested a review from analogrelay May 14, 2020 23:34
@analogrelay
Copy link
Contributor

Seems like an interesting experiment. It'll be interesting if it works. I will say it's fairly uncommon for us to get misreported issues in this repo. Certainly some issues end up being runtime problems, but we don't get a lot of issues where the author was confused.

Still, seems reasonable. Though I don't think I should go ahead an approve new issue management flows a day before leaving 😄

- name: Issue with .NET Core SDK
url: https://github.com/dotnet/sdk/issues/new/choose
about: Please open issues with the .NET Core SDK in their repo
- name: Issue with Entity Framework
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Entity Framework Core instead?
Or maybe, we should even have two separate ones for EF and EF Core?

@ajcvickers thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to Entity Framework Core. I can add regular EF, if you let me know the URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmosemsft Looks good the way it is now.

Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal, @danmosemsft.
I suggest we tweak it slightly.

@Pilchie Pilchie added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label May 15, 2020
@danmoseley
Copy link
Member Author

@mkArtakMSFT should be good to merge now?

Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks great!

Thanks @danmosemsft.

@danmoseley
Copy link
Member Author

@mkArtakMSFT can you merge it? Not sure whether it's polite for me to merge into your repo.

@mkArtakMSFT mkArtakMSFT merged commit 21e1020 into master May 17, 2020
@mkArtakMSFT mkArtakMSFT deleted the template branch May 17, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants