Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IComponentActivator #19642

Closed
wants to merge 13 commits into from
Closed

Add IComponentActivator #19642

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b822efc
Add IComponentActivator
Mar 6, 2020
295a477
Added missing DI registrations for SSB
Mar 6, 2020
dba8a02
Use default Activator if IComponentActivator is not specified in DI
stsrki Mar 6, 2020
6bffe40
Merge pull request #1 from dotnet/master
stsrki Jun 30, 2020
36feb0e
Merge with master
Jun 30, 2020
e6f84fb
Rename ComponentActivator to DefaultComponentActivator
Jun 30, 2020
2990453
Update src/Components/Components/src/ComponentActivator.cs
stsrki Jun 30, 2020
469091b
Update src/Components/Components/src/ComponentActivator.cs
stsrki Jun 30, 2020
a9d9656
Merge branch 'feat-component-activator' of https://github.com/stsrki/…
Jun 30, 2020
69cb2dc
IComponentActivator to return IComponent type
Jun 30, 2020
23e78d3
Register IComponentActivator as singleton
Jun 30, 2020
160f45c
Tests for default component activator
Jun 30, 2020
fcd0ac0
Rename ComponentActivator file to DefaultComponentActivator
Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Components/Server/src/DependencyInjection/ComponentServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public static IServerSideBlazorBuilder AddServerSideBlazor(this IServiceCollecti
services.AddScoped<IJSRuntime, RemoteJSRuntime>();
services.AddScoped<INavigationInterception, RemoteNavigationInterception>();
services.AddScoped<AuthenticationStateProvider, ServerAuthenticationStateProvider>();
services.AddScoped<IComponentActivator, ComponentActivator>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be now removed since activator will fallback to default implementation anyway.


services.TryAddEnumerable(ServiceDescriptor.Singleton<IConfigureOptions<CircuitOptions>, CircuitOptionsJSInteropDetailedErrorsConfiguration>());

Expand Down
1 change: 1 addition & 0 deletions src/Mvc/Mvc.ViewFeatures/src/DependencyInjection/MvcViewFeaturesMvcCoreBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ internal static void AddViewServices(IServiceCollection services)
services.TryAddScoped<NavigationManager, HttpNavigationManager>();
services.TryAddScoped<IJSRuntime, UnsupportedJavaScriptRuntime>();
services.TryAddScoped<INavigationInterception, UnsupportedNavigationInterception>();
services.TryAddScoped<IComponentActivator, ComponentActivator>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't the default activator be a singleton? It doesn't hold any state.


services.TryAddTransient<ControllerSaveTempDataPropertyFilter>();

Expand Down