Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelixPlatform_QuickListenerIsSupported fails on win11.arm64 in Helix #47065

Closed
eerhardt opened this issue Mar 6, 2023 · 4 comments
Closed

HelixPlatform_QuickListenerIsSupported fails on win11.arm64 in Helix #47065

eerhardt opened this issue Mar 6, 2023 · 4 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Milestone

Comments

@eerhardt
Copy link
Member

eerhardt commented Mar 6, 2023

The following test has been failing since Thursday on the win11.arm64 helix queue.

// This test isn't conditional on QuicListener.IsSupported. Instead, it verifies that HTTP/3 runs on expected CI platforms:
// 1. Windows 11 or later.
// 2. Linux with libmsquic package installed.
[ConditionalFact]
[SkipNonHelix]
[SkipOnAlpine("https://github.com/dotnet/aspnetcore/issues/46537")]
[SkipOnMariner("https://github.com/dotnet/aspnetcore/issues/46537")]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/46616", Queues = "Debian.12.Arm64.Open;")]
[OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "HTTP/3 isn't supported on MacOS.")]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win11_21H2)]
public void HelixPlatform_QuickListenerIsSupported()
{
Assert.True(QuicListener.IsSupported, "QuicListener.IsSupported should be true.");
Assert.True(new MsQuicSupportedAttribute().IsMet, "MsQuicSupported.IsMet should be true.");
}

It last passed on Thu at 6AM in this build.

Then it started failing on Thu at 6PM in this build.

Error message
QuicListener.IsSupported should be true.
Expected: True
Actual:   False


Stack trace
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Tests.WebHostTests.HelixPlatform_QuickListenerIsSupported() in /_/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs:line 35
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Looking through the changes that went into the repo in between those 2 builds, nothing jumps out as something that could have broken this. So maybe the Helix win11 arm64 machines changed?

cc @JamesNK @Tratcher

@eerhardt
Copy link
Member Author

eerhardt commented Mar 7, 2023

Looking through the changes that went into the repo in between those 2 builds, nothing jumps out as something that could have broken this.

Looking again, I see that the dotnet/runtime was updated in between those 2 builds.

@wfurt @ManickaP - I see dotnet/runtime#81742 is in the commit change list of the new dotnet/runtime. I also see dotnet/runtime#82780 disabled a QUIC test on arm.

Should I disable this test? Is this a known issue in Quic?

@wfurt
Copy link
Member

wfurt commented Mar 7, 2023

dotnet/runtime#81742 missed arm binary @eerhardt. It should be fixed once dotnet/msquic#131 floats to runtime (and eventually ASP.NET)
So probably yes, disable the test for now.

@JamesNK
Copy link
Member

JamesNK commented Mar 7, 2023

Add a skip for that queue and link to this issue to track

eerhardt added a commit to eerhardt/aspnetcore that referenced this issue Mar 7, 2023
The current version of msquic doesn't have win-arm64 binaries. See dotnet/msquic#131.

Issues tracking re-enabling the test is dotnet#47065
eerhardt added a commit that referenced this issue Mar 7, 2023
* Skip HelixPlatform_QuickListenerIsSupported on win-arm64

The current version of msquic doesn't have win-arm64 binaries. See dotnet/msquic#131.

Issues tracking re-enabling the test is #47065

* PR feedback
@adityamandaleeka adityamandaleeka added this to the Test failures milestone Mar 8, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
@JamesNK
Copy link
Member

JamesNK commented Oct 26, 2023

This looks like it was fixed with #50279 but wasn't closed. @mitchdenny did you intent to close this?

@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure test-fixed
Projects
None yet
Development

No branches or pull requests

9 participants