Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and Update BaseView #2363

Closed
aspnet-hello opened this issue Jan 1, 2018 · 2 comments
Closed

Review and Update BaseView #2363

aspnet-hello opened this issue Jan 1, 2018 · 2 comments
Assignees
@ajaybhargavb
Labels
Done This issue has been fixed task
Milestone
2.1.0-preview2

Comments

@aspnet-hello
Copy link

From @rynowak on Tuesday, June 6, 2017 11:34:06 PM

We made some changes to Razor codegen that could impact this class. We need to review this and determine what should be adjusted.

/cc @ajaybhargavb

Copied from original issue: dotnet/extensions#236
@aspnet-hello
Copy link
Author

From @rynowak on Friday, June 30, 2017 10:05:57 AM

This could happen at any time since it's not broken, moving this out.

@aspnet-hello aspnet-hello added this to the 2.1.0-preview1 milestone Jan 1, 2018
@aspnet-hello aspnet-hello mentioned this issue Jan 1, 2018
Closed
This was referenced Mar 23, 2018
Merged
Merged
@ajaybhargavb
Copy link
Contributor

ajaybhargavb commented Mar 27, 2018 •
edited
Loading

dotnet/extensions@ac68db3 and aspnet/Diagnostics@7720041

@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed 2 - Working labels Mar 27, 2018
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
@pranavkm
Allow publish to work when BuildProjectReferences=false
9c3a331 
Fixes #2363
ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
@pranavkm
Allow publish to work when BuildProjectReferences=false
1b6ca7f 
Fixes #2363
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
Done This issue has been fixed task
Projects
None yet
Milestone
2.1.0-preview2
Development

No branches or pull requests
2 participants
@ajaybhargavb @aspnet-hello