Skip to content

Commit

Permalink
Revert Arcade version and workaround (#18724)
Browse files Browse the repository at this point in the history
  • Loading branch information
Tratcher authored Feb 1, 2020
1 parent b2e1218 commit 6255c1e
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 21 deletions.
4 changes: 0 additions & 4 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -342,10 +342,6 @@ if ($tmpBinaryLog) {
$MSBuildArguments += "/bl:$LogDir/Build.binlog"
}

# Prevent the root Directory.Build.props and Directory.Build.targets from being imported by files in the TempDir
Copy-Item (Join-Path $EngRoot 'Empty.Directory.Build.props') (Join-Path $TempDir 'Directory.Build.props') -ea Ignore
Copy-Item (Join-Path $EngRoot 'Empty.Directory.Build.targets') (Join-Path $TempDir 'Directory.Build.targets') -ea Ignore

# Capture MSBuild crash logs
$env:MSBUILDDEBUGPATH = $LogDir

Expand Down
2 changes: 0 additions & 2 deletions eng/Empty.Directory.Build.props

This file was deleted.

2 changes: 0 additions & 2 deletions eng/Empty.Directory.Build.targets

This file was deleted.

12 changes: 6 additions & 6 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -412,17 +412,17 @@
<Uri>https://github.com/dotnet/extensions</Uri>
<Sha>275e691f7e575f208290d1cbb8cb450f4a3a85d6</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.GenAPI" Version="5.0.0-beta.20076.3">
<Dependency Name="Microsoft.DotNet.GenAPI" Version="5.0.0-beta.20074.6">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>cc8fe69635c7c6e791c87540851aea75946945fa</Sha>
<Sha>841c83d8a5b8d8a6bd427f6798b086780138aa9a</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.20076.3">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.20074.6">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>cc8fe69635c7c6e791c87540851aea75946945fa</Sha>
<Sha>841c83d8a5b8d8a6bd427f6798b086780138aa9a</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="5.0.0-beta.20076.3">
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="5.0.0-beta.20074.6">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>cc8fe69635c7c6e791c87540851aea75946945fa</Sha>
<Sha>841c83d8a5b8d8a6bd427f6798b086780138aa9a</Sha>
</Dependency>
<Dependency Name="Microsoft.AspNetCore.Testing" Version="5.0.0-alpha.1.20079.1" CoherentParentDependency="Microsoft.AspNetCore.Razor.Language">
<Uri>https://github.com/dotnet/extensions</Uri>
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
-->
<PropertyGroup Label="Automated">
<!-- Packages from dotnet/arcade -->
<MicrosoftDotNetGenAPIPackageVersion>5.0.0-beta.20076.3</MicrosoftDotNetGenAPIPackageVersion>
<MicrosoftDotNetGenAPIPackageVersion>5.0.0-beta.20074.6</MicrosoftDotNetGenAPIPackageVersion>
<!-- Packages from dotnet/roslyn -->
<MicrosoftNetCompilersToolsetPackageVersion>3.5.0-beta2-20074-05</MicrosoftNetCompilersToolsetPackageVersion>
<!-- Packages from dotnet/core-setup -->
Expand Down
5 changes: 1 addition & 4 deletions eng/common/tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -655,9 +655,6 @@ Write-PipelineSetVariable -Name 'Artifacts.Log' -Value $LogDir
Write-PipelineSetVariable -Name 'TEMP' -Value $TempDir
Write-PipelineSetVariable -Name 'TMP' -Value $TempDir

$env:TEMP=$TempDir
$env:TMP=$TempDir

# Import custom tools configuration, if present in the repo.
# Note: Import in global scope so that the script set top-level variables without qualification.
if (!$disableConfigureToolsetImport) {
Expand All @@ -671,4 +668,4 @@ if (!$disableConfigureToolsetImport) {
}
}
}
}
}
4 changes: 2 additions & 2 deletions global.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"msbuild-sdks": {
"Yarn.MSBuild": "1.15.2",
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20076.3",
"Microsoft.DotNet.Helix.Sdk": "5.0.0-beta.20076.3"
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20074.6",
"Microsoft.DotNet.Helix.Sdk": "5.0.0-beta.20074.6"
}
}

0 comments on commit 6255c1e

Please sign in to comment.