Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc comments on WithVolume & WithBindMount #7791

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

DamianEdwards
Copy link
Member

Description

Improves the doc comments for the WithVolume and WithBindMount methods based on user feedback.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • n/a
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot bot review requested due to automatic review settings February 26, 2025 17:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@DamianEdwards DamianEdwards merged commit b27731d into main Feb 26, 2025
71 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/withvolume-doc-comments branch February 26, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants