Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set parent relationships in the dashboard #7337

Merged
merged 5 commits into from
Feb 1, 2025

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jan 30, 2025

Description

Add a new API - WithParentRelationship that can be set to nest resources.

Fix an issue in snapshot properties where it was overwriting previous properties by setting to
a new collection on publish. Needs to update/append to the property collection.

Allow Projects to be parents, not just Containers.

Fix #7259

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@eerhardt eerhardt requested a review from davidfowl January 30, 2025 23:40
Add a new API - WithParentRelationship that can be set to nest resources.

Fix an issue in snapshot properties where it was overwriting previous properties by setting to
a new collection on publish. Needs to update/append to the property collection.

Allow Projects to be parents, not just Containers.

Fix dotnet#7259
@eerhardt eerhardt marked this pull request as ready for review January 31, 2025 16:30
@eerhardt eerhardt requested a review from mitchdenny as a code owner January 31, 2025 16:30
@eerhardt eerhardt requested a review from JamesNK January 31, 2025 16:30
@eerhardt
Copy link
Member Author

I found 3 more places we should set this by default - our azure emulators that need to spin up other containers.

image

@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit e0079f9 into dotnet:main Feb 1, 2025
9 checks passed
@davidfowl
Copy link
Member

I assume executables also work.

@eerhardt eerhardt deleted the NestSidecar branch February 3, 2025 20:34
@eerhardt
Copy link
Member Author

eerhardt commented Feb 4, 2025

I assume executables also work.

Yes, they do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest sidecar type resources by default in Dashboard
2 participants