-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Azure ServiceBus persistent container support #7136
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3be1e3d
Fix Azure ServiceBus persistent container support
sebastienros 86513bf
Refactor state persistence
sebastienros 1e9de41
Fix tests
sebastienros 97ce49c
PR feedback
sebastienros ac1e1f5
Fix build
sebastienros 3ebd0da
Merge remote-tracking branch 'origin/main' into sebros/sbpersist
sebastienros 4ffcda7
Test AspireStore
sebastienros 650e3df
Refactor KeyValueStore
sebastienros d929346
Add tests
sebastienros fcb23e7
Update src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs
sebastienros d031cd2
Use /obj folder to store files
sebastienros 376fcca
Create ResourcesPreparingEvent
sebastienros 5620c61
Merge remote-tracking branch 'origin/main' into sebros/sbpersist
sebastienros b8a1025
Remove unused AddPersistentParameter
sebastienros 727f0f0
Only fallback folder on ENV
sebastienros 417c0ff
Fix method documentation
sebastienros 663ee7a
Remove newly added event
sebastienros 33868bc
Merge remote-tracking branch 'origin/main' into sebros/sbpersist
sebastienros ec769ed
Fix tests
sebastienros e691cb9
Use temp path for store in functional tests
sebastienros 21808c5
PR feedback
sebastienros ad785ef
Moving things
sebastienros 1bd23ae
Merge remote-tracking branch 'origin/main' into sebros/sbpersist
sebastienros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
287 changes: 165 additions & 122 deletions
287
src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Security.Cryptography; | ||
|
||
namespace Aspire.Hosting; | ||
|
||
internal sealed class AspireStore : IAspireStore | ||
{ | ||
private readonly string _basePath; | ||
|
||
/// <summary> | ||
/// Initializes a new instance of the <see cref="AspireStore"/> class with the specified base path. | ||
/// </summary> | ||
/// <param name="basePath">The base path for the store.</param> | ||
/// <returns>A new instance of <see cref="AspireStore"/>.</returns> | ||
public AspireStore(string basePath) | ||
{ | ||
ArgumentNullException.ThrowIfNull(basePath); | ||
|
||
_basePath = basePath; | ||
EnsureDirectory(); | ||
} | ||
|
||
public string BasePath => _basePath; | ||
|
||
public string GetFileNameWithContent(string filenameTemplate, string sourceFilename) | ||
{ | ||
ArgumentNullException.ThrowIfNullOrWhiteSpace(filenameTemplate); | ||
ArgumentNullException.ThrowIfNullOrWhiteSpace(sourceFilename); | ||
|
||
if (!File.Exists(sourceFilename)) | ||
{ | ||
throw new FileNotFoundException("The source file '{0}' does not exist.", sourceFilename); | ||
} | ||
|
||
EnsureDirectory(); | ||
|
||
// Strip any folder information from the filename. | ||
filenameTemplate = Path.GetFileName(filenameTemplate); | ||
|
||
var hashStream = File.OpenRead(sourceFilename); | ||
|
||
// Compute the hash of the content. | ||
var hash = SHA256.HashData(hashStream); | ||
|
||
hashStream.Dispose(); | ||
|
||
var name = Path.GetFileNameWithoutExtension(filenameTemplate); | ||
var ext = Path.GetExtension(filenameTemplate); | ||
var finalFilePath = Path.Combine(_basePath, $"{name}.{Convert.ToHexString(hash)[..12].ToLowerInvariant()}{ext}"); | ||
|
||
if (!File.Exists(finalFilePath)) | ||
{ | ||
File.Copy(sourceFilename, finalFilePath, overwrite: true); | ||
} | ||
|
||
return finalFilePath; | ||
} | ||
|
||
public string GetFileNameWithContent(string filenameTemplate, Stream contentStream) | ||
{ | ||
ArgumentNullException.ThrowIfNullOrWhiteSpace(filenameTemplate); | ||
ArgumentNullException.ThrowIfNull(contentStream); | ||
|
||
// Create a temporary file to write the content to. | ||
var tempFileName = Path.GetTempFileName(); | ||
|
||
// Write the content to the temporary file. | ||
using (var fileStream = File.OpenWrite(tempFileName)) | ||
{ | ||
contentStream.CopyTo(fileStream); | ||
} | ||
|
||
var finalFilePath = GetFileNameWithContent(filenameTemplate, tempFileName); | ||
|
||
try | ||
{ | ||
File.Delete(tempFileName); | ||
} | ||
catch | ||
{ | ||
} | ||
|
||
return finalFilePath; | ||
} | ||
|
||
/// <summary> | ||
/// Ensures that the directory for the store exists. | ||
/// </summary> | ||
private void EnsureDirectory() | ||
{ | ||
if (!string.IsNullOrEmpty(_basePath)) | ||
{ | ||
Directory.CreateDirectory(_basePath); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Reflection; | ||
|
||
namespace Aspire.Hosting; | ||
|
||
/// <summary> | ||
/// Provides extension methods for <see cref="IDistributedApplicationBuilder"/> to create an <see cref="IAspireStore"/> instance. | ||
/// </summary> | ||
public static class AspireStoreExtensions | ||
{ | ||
internal const string AspireStorePathKeyName = "Aspire:Store:Path"; | ||
|
||
/// <summary> | ||
/// Creates a new App Host store using the provided <paramref name="builder"/>. | ||
/// </summary> | ||
/// <param name="builder">The <see cref="IDistributedApplicationBuilder"/>.</param> | ||
/// <returns>The <see cref="IAspireStore"/>.</returns> | ||
public static IAspireStore CreateStore(this IDistributedApplicationBuilder builder) | ||
{ | ||
ArgumentNullException.ThrowIfNull(builder); | ||
|
||
var aspireDir = builder.Configuration[AspireStorePathKeyName]; | ||
|
||
if (string.IsNullOrWhiteSpace(aspireDir)) | ||
{ | ||
var assemblyMetadata = builder.AppHostAssembly?.GetCustomAttributes<AssemblyMetadataAttribute>(); | ||
aspireDir = GetMetadataValue(assemblyMetadata, "AppHostProjectBaseIntermediateOutputPath"); | ||
|
||
if (string.IsNullOrWhiteSpace(aspireDir)) | ||
{ | ||
throw new InvalidOperationException($"Could not determine an appropriate location for local storage. Set the {AspireStorePathKeyName} setting to a folder where the App Host content should be stored."); | ||
} | ||
} | ||
|
||
return new AspireStore(Path.Combine(aspireDir, ".aspire")); | ||
} | ||
|
||
/// <summary> | ||
/// Gets the metadata value for the specified key from the assembly metadata. | ||
/// </summary> | ||
/// <param name="assemblyMetadata">The assembly metadata.</param> | ||
/// <param name="key">The key to look for.</param> | ||
/// <returns>The metadata value if found; otherwise, null.</returns> | ||
private static string? GetMetadataValue(IEnumerable<AssemblyMetadataAttribute>? assemblyMetadata, string key) => | ||
assemblyMetadata?.FirstOrDefault(a => string.Equals(a.Key, key, StringComparison.OrdinalIgnoreCase))?.Value; | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,42 @@ | ||||||
// Licensed to the .NET Foundation under one or more agreements. | ||||||
// The .NET Foundation licenses this file to you under the MIT license. | ||||||
|
||||||
namespace Aspire.Hosting; | ||||||
|
||||||
/// <summary> | ||||||
/// Represents a store for managing files in the Aspire hosting environment that can be reused across runs. | ||||||
/// </summary> | ||||||
/// <remarks> | ||||||
/// The store is created in the ./obj folder of the Application Host. | ||||||
/// If the ASPIRE_STORE_DIR environment variable is set this will be used instead. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
/// | ||||||
/// The store is specific to a <see cref="IDistributedApplicationBuilder"/> instance such that each application can't | ||||||
/// conflict with others. A <em>.aspire</em> prefix is also used to ensure that the folder can be delete without impacting | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
/// unrelated files. | ||||||
/// </remarks> | ||||||
public interface IAspireStore | ||||||
{ | ||||||
/// <summary> | ||||||
/// Gets the base path of this store. | ||||||
/// </summary> | ||||||
string BasePath { get; } | ||||||
|
||||||
/// <summary> | ||||||
/// Gets a deterministic file path that is a copy of the content from the provided stream. | ||||||
/// The resulting file name will depend on the content of the stream. | ||||||
/// </summary> | ||||||
/// <param name="filenameTemplate">A file name to base the result on.</param> | ||||||
/// <param name="contentStream">A stream containing the content.</param> | ||||||
/// <returns>A deterministic file path with the same content as the provided stream.</returns> | ||||||
string GetFileNameWithContent(string filenameTemplate, Stream contentStream); | ||||||
|
||||||
/// <summary> | ||||||
/// Gets a deterministic file path that is a copy of the <paramref name="sourceFilename"/>. | ||||||
/// The resulting file name will depend on the content of the file. | ||||||
/// </summary> | ||||||
/// <param name="filenameTemplate">A file name to base the result on.</param> | ||||||
/// <param name="sourceFilename">An existing file.</param> | ||||||
/// <returns>A deterministic file path with the same content as <paramref name="sourceFilename"/>.</returns> | ||||||
/// <exception cref="FileNotFoundException">Thrown when the source file does not exist.</exception> | ||||||
string GetFileNameWithContent(string filenameTemplate, string sourceFilename); | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we can iterate on this API, so we don't have to block on this, but I think this is going to clutter up normal dev's intellisense. Normal apphost devs don't need to use this API, so I don't think it should be top-level like "AddContainer" or "AddPostgres", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to move to
Azure.Hosting.ApplicationModel
instead?