Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load plotly as a module on metrics page #4857

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Load plotly as a module on metrics page #4857

merged 3 commits into from
Jul 12, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 11, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes #4155

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 11, 2024
@JamesNK JamesNK added area-dashboard area-telemetry and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jul 12, 2024
@JamesNK JamesNK force-pushed the jamesnk/plotly-module branch from 643c324 to 6a3a628 Compare July 12, 2024 03:10
@JamesNK JamesNK enabled auto-merge (squash) July 12, 2024 03:47
tlmii
tlmii reviewed Jul 12, 2024
View reviewed changes
src/Aspire.Dashboard/Components/App.razor
@@ -28,7 +28,5 @@
<Routes @rendermode="@(new InteractiveServerRenderMode(prerender: false))" />
<script src="_framework/blazor.web.js"></script>
<script src="js/app.js"></script>
<script src="js/theme.js" type="module"></script>
Copy link
Member

@tlmii tlmii Jul 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does removing this (presumably leaving it to the module load in OnAfterRenderAsync in MainLayout) cause any delays in applying the theme on load? It feels like there could be a fairly substantial timing delay between when the two loads happen. But maybe it doesn't make a difference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think of that. Good point. I'll measure.

If I re-add it I'll put a comment explaining why.

@JamesNK JamesNK merged commit cf61a58 into main Jul 12, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/plotly-module branch July 12, 2024 05:00
radical added a commit to radical/aspire that referenced this pull request Jul 12, 2024
@radical
Squashed commit of the following:
84a7df1 
commit 9071c84
Author: Ankit Jain <[email protected]>
Date:   Fri Jul 12 19:04:26 2024 -0400

    fix e2e

commit 68a7ae0
Merge: 09acf2d 681f2e7
Author: Ankit Jain <[email protected]>
Date:   Fri Jul 12 18:57:33 2024 -0400

    Merge remote-tracking branch 'origin/main' into tests-out-of-repo

commit 681f2e7
Author: Dan Moseley <[email protected]>
Date:   Fri Jul 12 14:04:57 2024 -0600

    Make credscan run clean (dotnet#4876)

    * suppressions

    * more

    * typo

commit a133411
Author: Dan Moseley <[email protected]>
Date:   Fri Jul 12 08:42:40 2024 -0600

    add TSA config (dotnet#4860)

    * tsaconfig

    * more

    * remove the config per Matt

    * add policheck in 1ES template

    * policheck exclusions

commit cf61a58
Author: James Newton-King <[email protected]>
Date:   Fri Jul 12 13:00:02 2024 +0800

    Load plotly as a module on metrics page (dotnet#4857)

commit 09acf2d
Author: Ankit Jain <[email protected]>
Date:   Fri Jul 12 00:34:04 2024 -0400

    fix archive path for e2e

commit da382ff
Merge: 18b92c3 de35684
Author: Ankit Jain <[email protected]>
Date:   Fri Jul 12 00:12:02 2024 -0400

    Merge remote-tracking branch 'origin/main' into tests-out-of-repo

commit 18b92c3
Author: Ankit Jain <[email protected]>
Date:   Fri Jul 12 00:07:52 2024 -0400

    merge from playground branch

commit de35684
Author: James Newton-King <[email protected]>
Date:   Fri Jul 12 09:43:58 2024 +0800

    Add support for exemplars in metrics UI (dotnet#4629)

commit e23cd4c
Merge: ef3158b 9421fc8
Author: Ankit Jain <[email protected]>
Date:   Thu Jul 11 18:00:20 2024 -0400

    Merge remote-tracking branch 'origin/main' into tests-out-of-repo

commit ef3158b
Author: Ankit Jain <[email protected]>
Date:   Thu Jul 11 03:27:52 2024 -0400

    wip

commit 7c61df1
Author: Ankit Jain <[email protected]>
Date:   Thu Jul 11 02:48:20 2024 -0400

    fixies mores

commit d6e21ab
Author: Ankit Jain <[email protected]>
Date:   Thu Jul 11 03:10:21 2024 -0400

    share targets

commit 01e419d
Merge: 0741157 421f8b1
Author: Ankit Jain <[email protected]>
Date:   Thu Jul 11 03:00:16 2024 -0400

    Merge remote-tracking branch 'origin/main' into tests-out-of-repo

    # Conflicts:
    #	tests/helix/send-to-helix-inner.proj

commit 0741157
Merge: 3406514 f647a66
Author: Ankit Jain <[email protected]>
Date:   Tue Jul 9 18:43:36 2024 -0400

    Merge remote-tracking branch 'origin/main' into tests-out-of-repo

commit 3406514
Author: Ankit Jain <[email protected]>
Date:   Mon Jul 8 21:18:23 2024 -0400

    fix build

commit 3489ff3
Author: Ankit Jain <[email protected]>
Date:   Mon Jul 8 20:23:10 2024 -0400

    fix props generation

commit 6a6315f
Author: Ankit Jain <[email protected]>
Date:   Mon Jul 8 20:14:53 2024 -0400

    fix

commit 92642ea
Author: Ankit Jain <[email protected]>
Date:   Mon Jul 8 19:36:17 2024 -0400

    rename

commit 4bea9f4
Author: Ankit Jain <[email protected]>
Date:   Mon Jul 8 19:21:36 2024 -0400

    cleanup

# Conflicts:
#	tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj
#	tests/Shared/RepoTesting/Aspire.Testing.Repo.targets
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tlmii tlmii tlmii left review comments

@mitchdenny mitchdenny mitchdenny approved these changes

@drewnoakes drewnoakes Awaiting requested review from drewnoakes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@adamint adamint Awaiting requested review from adamint

@kvenkatrajan kvenkatrajan Awaiting requested review from kvenkatrajan

Assignees
No one assigned
Labels
area-dashboard area-telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

See whether plotly JavaScript can be imported on metrics page
3 participants
@JamesNK @mitchdenny @tlmii