Use OutDirName to determine the SymStore subdirectory name #5174
Conversation
- the name has to match the output directory binaries are built to. This directory is constructed in https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectLayout.props#L13 based on `OutDirName` - cherry-picked from 559d684 (#5150) then fixed up
|
@markwilkie where is the template I should add to this 'release/3.x' PR? |
|
The PR templates are linked here: https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskTellMode.md |
|
🆗 I followed the process for an Arcade tell mode change |
|
Not sure what dependencies (if any) 3x takes on the symstore directory. @tmat and @JohnTortugo ? |
|
From the publishing side we only reference the |
|
@markwilkie w/ the tell-mode info and label, am I waiting on anything else before merging? (No, I'm not authorized to merge into this branch.) |
|
What would be the downside/s of waiting for a bit for this to "bake"? I'd prefer this to be vetted for a while in master before porting. Thoughts? |
|
@markwilkie my concern is the potential to ship unaligned symbols again in 3.1.4. Suggest we let it bake some but make sure it gets into 'release/3.x' with time for dotnet/extensions to update Arcade bits before that release locks down. |
|
Sounds good. When's a good target date do you think @dougbu ? |
|
Let's say 12 April. |
|
Sounds good. If you could ping me again middle of the month and let's do this. :) cc/ @riarenas @ilyas1974 @mmitche for visibility |
|
@markwilkie the time is ripe to get this in. Again, we'd like to avoid mismatched symbols in 3.1.4. The dotnet/runtime, dotnet/extensions, and dotnet/aspnetcore repos are all at Arcade SDK v5.0.0-beta.20201.2 and that contains @tmat's 559d684 fix. I have not heard of any issues since getting the new Arcade bits. |
|
I'm good with this. Thanks! |
|
@markwilkie you're welcome. But, I can't merge into this branch (hint, hint) |
|
Thanks @markwilkie❕ What's the usual time between a 'release/3.x' merge and the new build showing up in Maestro++? In addition, what is your perspective on updating Arcade in the three repos with matching src/ and ref/ project names versus doing it across every repo building for 3.1.4? /cc @wtgodbe @mmitche |
|
Once this PR merges, and an arcade-validation official build with the changes finishes, it will be available in the channel: |
https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectLayout.props#L13 based on
OutDirNameDescription
Because
$(MSBuildProjectName)is not necessarily unique within a repo e.g. matching ref/ and src/ projects, we can end up overwriting symbols. This one word change ensures symbols always go to unique directories.Customer Impact
Without this, customers may be unable to download symbols while debugging.
The issue has recently led to problems pushing new Razor bits into Visual Studio, That could mean we delay getting other fixes to customers.
Regression
No, this problem has been around for a long time. Was previously missed because symptoms involve a build race and tend not to break every assembly : symbol relationship.
Risk
Very low.
Workarounds
No known customer workarounds.
It may be possible to change enough in individual repos to avoid problems. But, something like renaming the non-unique projects is likely much riskier.