Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve publishing performance (by a lot) #5096

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Improve publishing performance (by a lot) #5096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5550682
Improve publishing performance (by a lot)
mmitche Mar 11, 2020
0c84d92
Respond to feedback
mmitche Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@
Text="No manifest file was found in the provided path: $(ManifestsBasePath)" />

<!--
**Iterate** publishing assets from each manifest file.
Publish artifacts from all manifests.
-->
<PublishArtifactsInManifest
InternalBuild="$(IsInternalBuild)"
TargetFeedConfig="@(TargetFeedConfig)"
BARBuildId="$(BARBuildId)"
MaestroApiEndpoint="$(MaestroApiEndpoint)"
BuildAssetRegistryToken="$(BuildAssetRegistryToken)"
AssetManifestPath="%(ManifestFiles.Identity)"
AssetManifestPaths="@(ManifestFiles)"
mmitche marked this conversation as resolved.
Show resolved Hide resolved
BlobAssetsBasePath="$(BlobBasePath)"
PackageAssetsBasePath="$(PackageBasePath)"
NugetPath="$(NugetPath)"
Expand Down
26 changes: 9 additions & 17 deletions src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SetupTargetFeeds.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,6 @@
Type="AzDoNugetFeed"
Token="$(AzureDevOpsStaticTransportFeedKey)" />

<TargetFeedConfig
AssetSelection="NonShippingOnly"
Include="Symbols"
TargetURL="$(AzureDevOpsStaticSymbolsFeed)"
Isolated="false"
Type="AzDoNugetFeed"
Token="$(AzureDevOpsStaticSymbolsFeedKey)" />

<!-- These feeds are marked as isolated even though they are not. We allow overwrite
the old data with the new. -->
<TargetFeedConfig
Expand Down Expand Up @@ -306,8 +298,15 @@
- Installers and checksums to desired storage accounts.
-->
<ItemGroup Condition="'@(TargetFeedConfig)' == '' AND '$(IsStableBuild)' == 'false' AND '$(IsInternalBuild)' == 'false'">
<TargetFeedConfig
Include="Package;Symbols;OSX;Deb;Rpm;Node;BinaryLayout;Installer;Checksum;Maven;VSIX;Badge;Other"
<TargetFeedConfig Condition="'$(PublishInstallersAndChecksums)' == 'true'"
mmitche marked this conversation as resolved.
Show resolved Hide resolved
Include="Symbols"
TargetURL="$(TargetStaticFeed)"
Isolated="false"
Type="AzureStorageFeed"
Token="$(AzureStorageTargetFeedPAT)" />

<TargetFeedConfig Condition="'$(PublishInstallersAndChecksums)' != 'true'"
mmitche marked this conversation as resolved.
Show resolved Hide resolved
Include="Symbols;OSX;Deb;Rpm;Node;BinaryLayout;Installer;Checksum;Maven;VSIX;Badge;Other"
TargetURL="$(TargetStaticFeed)"
Isolated="false"
Type="AzureStorageFeed"
Expand Down Expand Up @@ -344,13 +343,6 @@
Type="AzDoNugetFeed"
Token="$(AzureDevOpsStaticTransportFeedKey)"
AssetSelection="NonShippingOnly" />

<TargetFeedConfig
Include="Symbols"
TargetURL="$(AzureDevOpsStaticSymbolsFeed)"
Isolated="false"
Type="AzDoNugetFeed"
Token="$(AzureDevOpsStaticSymbolsFeedKey)" />
</ItemGroup>

<Error
Expand Down
Loading