Bring back properties until we re-bootstrap to a newer Arcade SDK #15330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
changed the title
|
Can you just pass these in as global properties to the arcade build in the VMR until we re-bootstrap? |
|
Sure but this might have consequences if a component redefines those properties in this repo (which I don't think is the case). I think keeping those as local properties is better (even for the workaround). We should be able to remove this again soon. |
mmitche
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially unblocks dotnet/sdk#45353
I removed these properties in 3f34435. I should have waited until the VMR uses a newer Arcade Sdk with the TFM change. Bring this back to unblock the arcade -> sdk PR.
To double check: