Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on missing SB intermediate prefix #14458

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Feb 6, 2024

Fixes dotnet/source-build#3373

This PR updates the Source-Build metadata attribute checks. If a SourceBuild element is placed on a non-intermediate, it triggers a failure and alerts the user. This ensures SourceBuild elements are exclusive to intermediates, avoiding duplicate package references from non-intermediate packages with the metadata elements, and mandates proper SourceBuild element usage.

@ellahathaway ellahathaway marked this pull request as ready for review February 10, 2024 00:24
@ellahathaway ellahathaway requested a review from a team February 10, 2024 00:24
@ellahathaway ellahathaway merged commit 75683b3 into dotnet:main Feb 12, 2024
11 checks passed
@ellahathaway ellahathaway deleted the sb-metadata-warnings branch February 12, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the UX and guideance around the SourceBuild metadata in the Version.Details.xml
2 participants