Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make engine signing map during post-build signing a bit smarter #7908

Closed
2 tasks
mmitche opened this issue Sep 17, 2021 · 0 comments · Fixed by #8002
Closed
2 tasks

Make engine signing map during post-build signing a bit smarter #7908

mmitche opened this issue Sep 17, 2021 · 0 comments · Fixed by #8002
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Sep 17, 2021

  • This issue is blocking
  • This issue is causing unreasonable pain

This follows up on https://github.com/dotnet/core-eng/issues/14375 and is about making the engine signing map here a bit smarter.

This will fail if we have two files within the same drop that have the same name but different hashes. This appears to be handled gracefully within the rest of the tool (sign the one that needs signing), but the engine map uses the original file name thus causes hash collisions.

Technically, there's nothing wrong with having two exes with the same name have different signatures. We could make the map key a bit smarter and handle this case more gracefully. It is better though to have the same files have the same hashes (e.g. hosting bundle chained runtime exe and runtime exe are the same thing, and so should have the same file hash and signing timestamps).

@ghost ghost added the Needs Triage A new issue that needs to be associated with an epic. label Sep 17, 2021
@ghost ghost removed the Needs Triage A new issue that needs to be associated with an epic. label Oct 2, 2021
@michellemcdaniel michellemcdaniel self-assigned this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants