Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to where the branch relationships are defined in automated merge PRs #6409

Closed
2 tasks
rainersigwald opened this issue Oct 16, 2020 · 2 comments · Fixed by #6443
Closed
2 tasks

Link to where the branch relationships are defined in automated merge PRs #6409

rainersigwald opened this issue Oct 16, 2020 · 2 comments · Fixed by #6443

Comments

@rainersigwald
Copy link
Member

  • This issue is blocking
  • This issue is causing unreasonable pain

@dotnet-maestro-bot is sending nice PRs (like dotnet/msbuild#5806). They have a great link to the script that makes the PR (thanks!) but sometimes I'd like to know why a PR is happening. I remember that there's a repo somewhere with a bunch of data about the various repos and branches and relationships like "merge branch X into branch Y at cadence Z". But I don't usually remember exactly where that is.

Could it be linked in the PRs? Bonus points if the link goes directly to the line that cause the individual PR but just a static pointer to the file would be great.

@dagood
Copy link
Member

dagood commented Oct 16, 2020

You're looking for https://github.com/dotnet/versions/blob/master/Maestro/subscriptions.json, and yeah, should be easy enough to add the static URL.

Adding dynamic stuff gets more involved... would be a feature to add to https://github.com/dotnet/versions/tree/master/Maestro, working through it something like this:

  1. Have the service figure out/store which lines of JSON defined the subscription.
  2. Replace some token like <subscriptions-json-lines> with the value when it appears in a subscription.
    • <trigger-repo> works like this.
  3. Handle the new arg in the GitHubMergeBranches.ps1.
  4. Ask core-eng to deploy a new build of the Maestro service (not Maestro++).
  5. Add the new "SubscriptionsJsonLines": "<subscriptions-json-lines>" arg mapping to each mirror subscription to link it all up.

@rainersigwald
Copy link
Member Author

Yeah, the static URL should be fine. Doing it with detail sounds like more trouble than it's worth.

rainersigwald added a commit to rainersigwald/arcade that referenced this issue Oct 23, 2020
Link to the file that defines the merge configuration in merge PRs.

Fixes dotnet#6409.
rainersigwald added a commit to rainersigwald/arcade that referenced this issue Apr 14, 2021
Link to the file that defines the merge configuration in merge PRs.

Fixes dotnet#6409.
rainersigwald added a commit that referenced this issue May 7, 2021
Link to the file that defines the merge configuration in merge PRs.

Fixes #6409.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants