Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the BAR token in darc #4415

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

premun
Copy link
Member

@premun premun commented Feb 5, 2025

Token is no longer supported (#4312)

darc will

  • stop reading/storing the BAR token from the local settings
  • stop using it if it's supplied as an argument (but not fail yet)
  • warn if it's supplied
  • stop giving a warning when the user has not called darc authenticate yet

@premun premun requested review from Copilot and dkurepa February 5, 2025 12:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@premun premun enabled auto-merge (squash) February 5, 2025 12:26
@premun premun merged commit b5e6b42 into dotnet:main Feb 5, 2025
9 checks passed
@premun premun deleted the prvysoky/no-darc-bar-token branch February 5, 2025 12:37
premun added a commit to premun/arcade-services that referenced this pull request Feb 5, 2025
Partially reverted dotnet#4415 where we still want to be able to pass in the token. This happens in the scenario tests where we get it from Azure CLI manually.
premun added a commit that referenced this pull request Feb 5, 2025
Partially reverted #4415
where we still want to be able to pass in the token. This happens in the
scenario tests where we get it from Azure CLI manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants