Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Octokit to 12.0 to fix int overflows #3613

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Bump Octokit to 12.0 to fix int overflows #3613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
<PackageVersion Include="NuGet.Protocol" Version="6.9.1" />
<PackageVersion Include="NUnit" Version="4.0.1" />
<PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageVersion Include="Octokit" Version="10.0.0" />
<PackageVersion Include="Octokit" Version="12.0.0" />
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.8.1" />
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="1.8.1" />
<PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.8.1" />
Expand Down
15 changes: 3 additions & 12 deletions src/Maestro/SubscriptionActorService/PullRequestPolicyFailureNotifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,8 @@ public async Task TagSourceRepositoryGitHubContactsAsync(InProgressPullRequest p
- If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
- For more details, please read [the Arcade Darc documentation](https://github.com/dotnet/arcade/blob/main/Documentation/Darc.md#update-subscription)
";
try
{
await gitHubClient.Issue.Comment.Create(owner, repo, prIssueId, sourceRepoNotificationComment);
pr.SourceRepoNotified = true;
}
catch (OverflowException)
{
// There is a bug in Octokit that causes an overflow exception when the comment ID is > int.MaxValue
// The comment gets posted but we can't serialize the response and we do not note down that we've notified the source repo
// https://github.com/dotnet/arcade-services/issues/3601
pr.SourceRepoNotified = true;
}

await gitHubClient.Issue.Comment.Create(owner, repo, prIssueId, sourceRepoNotificationComment);
pr.SourceRepoNotified = true;
}
}