Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dependency removal #4390

Closed
premun opened this issue Jan 28, 2025 · 2 comments
Closed

Add support for dependency removal #4390

premun opened this issue Jan 28, 2025 · 2 comments
Assignees
@dkurepa

Comments

@premun
Copy link
Member

premun commented Jan 28, 2025 •
edited
Loading

Context

Current code that manages dependencies in repo files (DependencyFileManager) does not support removal of dependencies.
We will need this when resolving dependency file conflicts during code flows.

Goal

  • Add a RemoveDependency method to DependencyFileManager which already has AddDependency and UpdateDependencies methods.
    • This should only affect Version.Details.xml and Versions.props, not the other files
  • Add tests
@premun
Copy link
Member Author

premun commented Jan 28, 2025

This is needed for #4345

@dkurepa dkurepa mentioned this issue Jan 31, 2025
Merged
dkurepa added a commit that referenced this issue Feb 4, 2025
@dkurepa
Add RemoveDependency method to DependencyFileManager (#4405)
71e3456 
<!-- Link the GitHub or AzDO issue this pull request is associated with.
Please copy and paste the full URL rather than using the
dotnet/arcade-services# syntax -->
#4390
Adds a `RemoveDependencyAsync` method with the same API as
`AddDependencyAsync`
@dkurepa
Copy link
Member

dkurepa commented Feb 5, 2025

This has been completed, the method now exists

@dkurepa dkurepa closed this as completed Feb 5, 2025
@premun premun mentioned this issue Feb 10, 2025
Merged
premun added a commit that referenced this issue Feb 10, 2025
@premun
Use Add/RemoveDependency during VMR test setup (#4439)
e247c1b 
With the addition of `RemoveDependencyAsync`, we can stop generating
XMLs when we need to omit a package inside a test.

#4390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkurepa dkurepa

Labels
None yet
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@premun @dkurepa