[Xamarin.Android.Build.Tasks] Rework AsyncTask to use ConfigureAwait #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
changed the title
dellis1972
added
do-not-merge
dellis1972
force-pushed
the
asyncstuff
branch
2 times, most recently
from
b5759fd to
96c885c
Compare
dellis1972
changed the title
dellis1972
changed the title
dellis1972
changed the title
We should be using `ConfigureAwait(false)` for our `Task.Run` calls to ensure that the Continuations do NOT run on the main thread. This is probably the reason why VS locks up when we call these methods. The Continuation which calls `Complete` is trying to run on the UI thread, which will be locked waiting for the Task to complete. We should also provide the Cancelation Token and the TaskScheduler for the `Parallel.ForEach` calls.
dellis1972
force-pushed
the
asyncstuff
branch
from
a378608 to
7d77a39
Compare
|
|
||
| task.ContinueWith ( (t) => { | ||
| Complete (); | ||
| }); | ||
| }).ConfigureAwait (false); |
There was a problem hiding this comment.
I'm not sure ConfigureAwait(false) does anything unless you are awaiting it. I think it only controls the code after an await statement.
I think you need to passing the options to an overload of ContinueWith: https://msdn.microsoft.com/en-us/library/dd321561(v=vs.110).aspx
Probably not a way to write a unit test for this to know if it's for sure correct...
jonpryor
pushed a commit
that referenced
this pull request
Jul 18, 2022
…7123) Context: e1af958 Context: #7163 Changes: dotnet/java-interop@c942ab6...fadbb82 * dotnet/java-interop@fadbb82c: [generator] Add support for @explicitInterface metadata (#1006) * dotnet/java-interop@3e4a3c4f: [Java.Interop.Tools.JavaCallableWrappers] JavaCallableMethodClassifier (#998) dotnet/java-interop@3e4a3c4f reworked how `Java.Interop.Tools.JavaCallableWrappers.JavaCallableWrapperGenerator` can be used to find JNI marshal methods. Update `Xamarin.Android.Build.Tasks.dll` to provide a `JavaCallableMethodClassifier` to `JavaCallableWrapperGenerator`, collecting Cecil `MethodDefinition` instances for JNI marshal methods which can be created at build time via LLVM Marshal Methods. Methods which cannot be created at build time include methods with `[Export]`. Once candidate LLVM marshal methods are found, the marshal method is updated to have the [`UnmanagedCallersOnlyAttribute` attribute][0], and related System.Reflection.Emit-based infrastructure such as the `Get…Handler()` methods and `cb_…` fields are removed. As with e1af958, this feature is *not* enabled by default, and remains a xamarin-android Build time configuration option. [0]:https://docs.microsoft.com/dotnet/api/system.runtime.interopservices.unmanagedcallersonlyattribute?view=net-6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using
ConfigureAwait(false)for ourTask.Runcalls to ensure that the Continuations do NOT run on the
main thread. This is probably the reason why VS locks up
when we call these methods. The Continuation which calls
Completeis trying to run on the UI thread, which willbe locked waiting for the Task to complete.
We should also provide the Cancelation Token and the
TaskScheduler for the
Parallel.ForEachcalls.