Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] A few more instances of DesignTime errors #889

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

dellis1972
Copy link
Contributor

We have a couple more Tasks which require the
ContinueOnError="$(DesignTimeBuild)"
attribute to avoid messing up the Visual Studio lanuage service.

We have a couple more Tasks which require the
	`ContinueOnError="$(DesignTimeBuild)"`
attribute to avoid messing up the Visual Studio lanuage service.
@jonpryor jonpryor merged commit 87411b5 into dotnet:master Sep 22, 2017
jonpryor pushed a commit that referenced this pull request Sep 22, 2017
…rs (#889)

We have a couple more Tasks which require the
	`ContinueOnError="$(DesignTimeBuild)"`
attribute to avoid messing up the Visual Studio lanuage service.
jonpryor pushed a commit that referenced this pull request Oct 15, 2021
Context: dotnet/java-interop@846f211

Changes: dotnet/java-interop@c936d09...7c8d463

  * dotnet/java-interop@7c8d4638: [build] Fix -t:Prepare on Linux (#892)
  * dotnet/java-interop@41ba3485: [tests] Add net6.0 TargetFramework. (#888)
  * dotnet/java-interop@403dd37a: [class-parse] Ignore .jnilib files within .jar files (#890)
  * dotnet/java-interop@bda6be43: [class-parse] Add support for some JDK-11 constant pool types (#889)
  * dotnet/java-interop@4277ac96: Bump to xamarin/xamarin-android-tools/main@34e98e2b (#887)
  * dotnet/java-interop@846f2116: [generator] Remove buggy annotation loose match (#886)

Commit dotnet/java-interop@846f2116 made our annotation support more
accurate, which had a side-effect of introducing changes to generated
custom attributes.

Update `tests/api-compatibility/acceptable-breakages*.txt` to deal
with the fallout from dotnet/java-interop@846f2116.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants