[ci] Split up signing for files to be notarized #7321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a little better, though we may want to further split up the set of binutils lib files. That can happen in the future if needed.
|
|
Testing this a second time to see if the notarization stage succeeds: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6625844&view=results |
jonathanpeppers
approved these changes
Aug 30, 2022
The signing steps that run on macOS to prepare a PKG for notarization have been slow and are frequently failing. Attempt to fix this by splitting up the files we send to ESRP on macOS into multiple batches to hopefully put less pressure on the service.
pjcollins
added a commit
that referenced
this pull request
Aug 30, 2022
The signing steps that run on macOS to prepare a PKG for notarization have been slow and are frequently failing. Attempt to fix this by splitting up the files we send to ESRP on macOS into multiple batches to hopefully put less pressure on the service. A `signClassicPkgContent` parameter has also been added to allow us to skip these steps while testing, or when building .NET release branches if needed. MicroBuild tooling has also been updated to the latest versions.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 31, 2022
* main: [ci] Split up signing for files to be notarized (dotnet#7321) [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311) [ci] Skip classic tests on .NET release branches (dotnet#7312) [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320) Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308) Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 31, 2022
* mm-runtime: [ci] Split up signing for files to be notarized (dotnet#7321) [ci] Add support to net7.0 for multi-targeting in VS (dotnet#7311) [ci] Skip classic tests on .NET release branches (dotnet#7312) [tests] Use `$(AndroidSdkPlatformToolsVersion)`=33.0.3 (dotnet#7320) Bump to xamarin/java.interop/main@4f813cb2 (dotnet#7308) Bump to mono/mono.posix@d8994ca, dotnet/android-libzipsharp@98e9173 (dotnet#7309)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signing steps that run on macOS to prepare a PKG for notarization
have been slow and are frequently failing. Attempt to fix this by
splitting up the files we send to ESRP on macOS into multiple batches to
hopefully put less pressure on the service.
A
signClassicPkgContentparameter has also been added to allow us toskip these steps while testing, or when building .NET release branches if
needed.
MicroBuild tooling has also been updated to the latest versions.