Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono.Android-Tests] Update ignored .NET 6 tests #5802

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Mar 30, 2021

A few tests which were previously failing have been fixed and can now
be enabled. Additionally, now that dotnet/runtime has removed the
incomplete OpenSSL support on Android, we can enable more tests
that used various System.Security.Cryptography APIs directly or
indirectly.

There are still some SSL related test failures that are being ignored
that are generally being tracked in dotnet/runtime#45741.

A few tests which were previously failing have been fixed and can now
be enabled.  Additionally, now that dotnet/runtime has removed the
incomplete (non-existant?) OpenSSL support on Android, we can enable
more tests that used various crypto APIs.

There are still some SSL related test failures that are being ignored
that require further investigation, though I believe that some of these
cases may never be supported.
@pjcollins pjcollins marked this pull request as ready for review March 31, 2021 20:04
@pjcollins pjcollins requested a review from jonpryor as a code owner March 31, 2021 20:04
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem like the enabled tests are running and passing:

image

@pjcollins pjcollins merged commit 0b9395a into dotnet:main Apr 1, 2021
@pjcollins pjcollins deleted the runtime-tests-net6p4 branch April 1, 2021 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants