[Mono.Android] API-R enumification #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
dp4-enumification
branch
3 times, most recently
from
9df73d0 to
076d465
Compare
jonpryor
reviewed
May 27, 2020
| ?,30,android/accessibilityservice/AccessibilityService.GESTURE_4_FINGER_TRIPLE_TAP,39,,,, | ||
| ?,30,android/accessibilityservice/AccessibilityService.GESTURE_DOUBLE_TAP,17,,,, | ||
| ?,30,android/accessibilityservice/AccessibilityService.GESTURE_DOUBLE_TAP_AND_HOLD,18,,,, | ||
| E,30,android/accessibilityservice/AccessibilityService.GESTURE_2_FINGER_DOUBLE_TAP,20,Android.AccessibilityServices.AccessibilityGesture,TwoFingerDoubleTap,remove, |
There was a problem hiding this comment.
Silly Q, but does the map2.csv-parsing code in generator trim whitespace, such that we could make this "nicer" by adding spaces before/after the commas to make things line up "nicely"? Or is that just "crazy"?
E,30,android/accessibilityservice/AccessibilityService.GESTURE_2_FINGER_DOUBLE_TAP_AND_HOLD,40,Android.AccessibilityServices.AccessibilityGesture,TwoFingerDoubleTapAndHold,remove,
E,30,android/accessibilityservice/AccessibilityService.GESTURE_2_FINGER_SINGLE_TAP ,19,Android.AccessibilityServices.AccessibilityGesture,TwoFingerSingleTap ,remove,
E,30,android/accessibilityservice/AccessibilityService.GESTURE_2_FINGER_SWIPE_DOWN ,26,Android.AccessibilityServices.AccessibilityGesture,TwoFingerSwipeDown ,remove,
There was a problem hiding this comment.
It does trim, but I don't think it's going to make things nicer to read. You would have to pad to at least the size of the longest line which is 217 characters.
There was a problem hiding this comment.
You wouldn't necessarily need to pad the entire file, just each group of enums. If you don't think it'll be nicer to read, though, there's no point.
|
/azp run |
|
Pull request contains merge conflicts. |
jpobst
force-pushed
the
dp4-enumification
branch
2 times, most recently
from
8437f9f to
ee24f6e
Compare
jonpryor
pushed a commit
that referenced
this pull request
Jun 1, 2020
Enumification for API-R Developer Preview 4 (375e062). * Convert constant fields to enums as appropriate. * Update methods that take an `int` constant value to use new enums. There is some "acceptable-breakage" because I renamed some of the enums that were added in API-R with auto-generated names that had already been committed in 3ca2a07. Note that our enums are not "API-aware" so all enumifications are added for all API levels. That is, enums added in API-R get added to `android-21`, `android-22`, etc.…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumification for the API-R developer preview 4.
intconstant value to use new enums.There is some
acceptable-breakagebecause I renamed some of the enums that were added in API-R with auto-generated names that had already been committed in #4468. (Note that our enums are not "API-aware" so all enumifications are added for all API levels. That is, enums added in API-R get added toandroid-21,android-22, etc..)