Add new debugger-log-level option to debug.mono.log
#3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XA runtime supports setting the Mono debugger log level by setting the
`loglevel` option of the Mono runtime's `--debugger-agent` paremeter via the
`debug.mono.extra` system property (set by the IDEs). However, it turns out that
the IDEs (via AndroidTools) always set the log level to `0`. Fixing the issue
would require updates to AndroidTools and then IDEs, however.
To allow setting the debugger level without having to wait for the next IDE
release, this commit adds a new option to the `debug.mono.log` system property:
debugger-log-level=LEVEL
where `LEVEL` is a positive 32-bit signed integer or 0. This option will take
precedence when the level is set both in `debug.mono.extra` and `debug.mono.log`
system properties.
grendello
added
the
full-mono-integration-build
jonpryor
pushed a commit
that referenced
this pull request
Dec 12, 2019
The mono debugger infrastructure code supports a `loglevel` option, which the mono debugger team would like to set. In theory we have code to allow setting set it: the `debug.mono.extra` system property can contain a `loglevel=LEVEL` option, which is parsed by `mono_runtime_init()`/`parse_runtime_args()` when constructing the options for use with `mono_jit_parse_options()`. In practice, we don't: [all codepaths][0] which set `debug.mono.extra` always hardcode `loglevel=0`, with no way to override it. To allow the mono debugger team to *actually* set the `loglevel` value, add a new `debugger-log-level=LEVEL` option for use with the `debug.mono.log` system property: adb shell setprop debug.mono.log debugger-log-level=10 The `debug.mono.log` system property is comma-separated, so it can be used with other options as well: adb shell setprop debug.mono.log timing,gref,debugger-log-level=10 The `LEVEL` value is a positive 32-bit signed integer or `0`. This option will take precedence when the level is set in both the `debug.mono.extra` and `debug.mono.log` system properties. [0]: https://github.com/xamarin/androidtools/blob/master/Xamarin.AndroidTools/Debugging/DebuggingExtensions.cs#L92-L102
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XA runtime supports setting the Mono debugger log level by setting the
logleveloption of the Mono runtime's--debugger-agentparemeter via thedebug.mono.extrasystem property (set by the IDEs). However, it turns out thatthe IDEs (via AndroidTools) always set the log level to
0. Fixing the issuewould require updates to AndroidTools and then IDEs, however.
To allow setting the debugger level without having to wait for the next IDE
release, this commit adds a new option to the
debug.mono.logsystem property:where
LEVELis a positive 32-bit signed integer or 0. This option will takeprecedence when the level is set both in
debug.mono.extraanddebug.mono.logsystem properties.