Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AndroidManifest.xml] Determine which attributes to expose in Mono.Android. #9092

Closed
jpobst opened this issue Jul 9, 2024 · 0 comments · Fixed by #9096
Closed

[AndroidManifest.xml] Determine which attributes to expose in Mono.Android. #9092

jpobst opened this issue Jul 9, 2024 · 0 comments · Fixed by #9096
Assignees
Labels
Area: Mono.Android Issues with the Android API binding (Mono.Android.dll). enhancement Proposed change to current functionality.
Milestone

Comments

@jpobst
Copy link
Contributor

jpobst commented Jul 9, 2024

Context: #8272

Previously, we created a process for automatically determining the possible attributes for elements in AndroidManifest.xml and generating the Mono.Android [Application], [Activity], etc. attributes for users to consume. At the time, we merely created the process, but did not use it to expose any new attributes that have been added in previous Android API levels that we never added.

We should create a list of all attributes we are missing, and then determine which of them we want to expose for users. Note that our process that goes directly to the source finds many attributes that Android does not publicly document. Thus we will need to evaluate each attribute to determine if we want to expose it.

@jpobst jpobst added the Area: Mono.Android Issues with the Android API binding (Mono.Android.dll). label Jul 9, 2024
@jpobst jpobst added this to the .NET 9 milestone Jul 9, 2024
@jpobst jpobst self-assigned this Jul 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the needs-triage Issues that need to be assigned. label Jul 9, 2024
@jpobst jpobst added enhancement Proposed change to current functionality. and removed needs-triage Issues that need to be assigned. labels Jul 9, 2024
jonathanpeppers pushed a commit that referenced this issue Aug 6, 2024
…9096)

Fixes: #9092

Context: 3ab74db

Previously in commit 3ab74db, we created a process for automatically
determining the possible attributes for elements in
`AndroidManifest.xml` and generating the `[Application]`, `[Activity]`,
etc. attributes within `Mono.Android.dll` for users to consume.  At the
time, we merely created the process, but did not use it to expose any
new attributes that have been added in previous Android API levels that
we never exposed.

This commit exposes all Google-documented manifest attributes for the
elements we support.  The undocumented manifest attributes were moved
around in the file to a section denoted as "undocumented".
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Mono.Android Issues with the Android API binding (Mono.Android.dll). enhancement Proposed change to current functionality.
Projects
None yet
1 participant