Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fix DisplayMetrics.DENSITY_DEVICE_STABLE mapping #1084

Closed
jonpryor opened this issue Dec 7, 2017 · 2 comments
Closed

Properly fix DisplayMetrics.DENSITY_DEVICE_STABLE mapping #1084

jonpryor opened this issue Dec 7, 2017 · 2 comments
Assignees
@atsushieno
Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*.
Milestone
d15-6

Comments

@jonpryor
Copy link
Member

jonpryor commented Dec 7, 2017

Commit ef77024 manually removed the DisplayMetrics.DENSITY_DEVICE_STABLE enum binding, added by commit 50c0c15. This fix is incomplete/incorrect: the problem is that the underlying tooling in build-tools/enumification-helpers is doing "something" wrong, which means this invalid mapping will be reintroduced in the future.

We need to fix build-tools/enumification-helpers so that DisplayMetrics.DENSITY_DEVICE_STABLE isn't reintroduced for enum mapping.
@jonpryor jonpryor added the Area: xamarin-android Build Issues building the xamarin-android repo *itself*. label Dec 7, 2017
@jonpryor jonpryor added this to the d15-6 milestone Dec 7, 2017
@atsushieno
Copy link
Contributor

And someone needs to investigate why the PR build was green, which is why I think it's fine and it's merged.

@atsushieno atsushieno mentioned this issue Dec 7, 2017
Merged
@jonpryor jonpryor modified the milestones: d15-6, d15-7 Jan 4, 2018
@atsushieno
Copy link
Contributor

enumification-helpers is fixed, and we have already discovered that api-compatibility didn't run inter-api-diff and therefore this kind of failure didn't get detected. And there is already 6dfba92 so nothing needs to be tracked from this issue anymore. Closing.

jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Apr 18, 2020
@jonpryor
Bump to xamarin/monodroid@16cb1cb1
883c93a 
Changes: xamarin/monodroid@8466972...16cb1cb

  * xamarin/monodroid@16cb1cb1a: Bump to xamarin/androidtools@068e4f5 (dotnet#1084)
  * xamarin/monodroid@8f61f0cae: Bump to xamarin/android-sdk-installer@d9276b4 (dotnet#1085)
  * xamarin/monodroid@bec720cd0: Bump to xamarin/jar2xml@4125da65 (dotnet#1083)
  * xamarin/monodroid@a49e901d6: [tools/msbuild] update <BuildApk/> task inputs (dotnet#1082)
  * xamarin/monodroid@b9f16c002: Bump to xamarin/androidtools@5412dc8 (dotnet#1081)
  * xamarin/monodroid@673a74961: [.NET 5] fix for ALC isolation between assemblies (dotnet#1080)
@jonpryor jonpryor mentioned this issue Apr 18, 2020
Merged
jonpryor added a commit that referenced this issue Apr 19, 2020
@jonpryor
Bump to xamarin/monodroid@16cb1cb1 (#4581)
ee3a0c5 
Changes: xamarin/monodroid@8466972...16cb1cb

  * xamarin/monodroid@16cb1cb1a: Bump to xamarin/androidtools@068e4f5 (#1084)
  * xamarin/monodroid@8f61f0cae: Bump to xamarin/android-sdk-installer@d9276b4 (#1085)
  * xamarin/monodroid@bec720cd0: Bump to xamarin/jar2xml@4125da65 (#1083)
  * xamarin/monodroid@a49e901d6: [tools/msbuild] update <BuildApk/> task inputs (#1082)
  * xamarin/monodroid@b9f16c002: Bump to xamarin/androidtools@5412dc8 (#1081)
  * xamarin/monodroid@673a74961: [.NET 5] fix for ALC isolation between assemblies (#1080)
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atsushieno atsushieno

Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*.
Projects
None yet
Milestone
d15-6
Development

No branches or pull requests
2 participants
@atsushieno @jonpryor