-
Notifications
You must be signed in to change notification settings - Fork 538
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Mono.Android] Fix wrong value for
ApplicationExitInfoReason.Other
(#…
…9003) Fixes: #9000 Context: 3ca2a07 Context: 379f7cd The field [`ApplicationExitInfo.REASON_OTHER`][0] was added in API-30, and in our infinite wisdom we enumified this member in API-R Developer Preview 2 (3ca2a07) instead of waiting for the final API contract. In API-R DP2, `ApplicationExitInfo.REASON_OTHER` had the value 10, and was enumified as `ApplicationExitInfoReasonType.ReasonUnknown` with value 10. `ApplicationExitInfoReasonType` was renamed to `ApplicationExitInfoReason` in 379f7cd with API-R Developer Preview 4. The value of `ApplicationExitInfo.REASON_OTHER` [changed to 13][1] in API-R Developer Preview 3, but we did not notice and did not update the previous enumification. This process has been mitigated since, as we no longer enumify unstable API levels: we wait until Google marks the API as "stable" before we perform enumification. Update the enum to the correct value so it will be correct in .NET 9+. [0]: https://developer.android.com/reference/android/app/ApplicationExitInfo#REASON_OTHER [1]: https://developer.android.com/sdk/api_diff/r-dp3-incr/changes/android.app.ApplicationExitInfo
- Loading branch information
Showing
4 changed files
with
8 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
tests/api-compatibility/acceptable-breakages-vReference-net9.0.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
Compat issues with assembly Mono.Android: | ||
CannotAddAbstractMembers : Member 'public void Android.Net.Wifi.WifiManager.WpsCallback.OnFailed(Android.Net.Wifi.WpsFailureReason)' is abstract in the implementation but is missing in the contract. | ||
EnumValuesMustMatch : Enum value 'Android.App.ApplicationExitInfoReason Android.App.ApplicationExitInfoReason.Other' is (System.Int32)13 in the implementation but (System.Int32)10 in the contract. |