Test | Skip unsupported tests on Synapse (#1884)

dotnet · Jan 11, 2023 · af0a376 · af0a376
1 parent c585669
commit af0a376
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/TransactionPoolTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/TransactionPoolTest.cs
@@ -8,8 +8,9 @@ public static class TransactionPoolTest
         /// <summary>
         /// Tests if connections in a distributed transaction are put into a transaction pool. Also checks that clearallpools 
         /// does not clear transaction connections and that the transaction root is put into "stasis" when closed
+        /// Synapse: only supports local transaction request.
         /// </summary>
-        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
+        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         [ClassData(typeof(ConnectionPoolConnectionStringProvider))]
         public static void BasicTransactionPoolTest(string connectionString)
         {
@@ -63,9 +64,10 @@ public static void BasicTransactionPoolTest(string connectionString)
 
         /// <summary>
         /// Checks that connections in the transaction pool are not cleaned out, and the root transaction is put into "stasis" when it ages
+        /// Synapse: only supports local transaction request.
         /// </summary>
         /// <param name="connectionString"></param>
-        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
+        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         [ClassData(typeof(ConnectionPoolConnectionStringProvider))]
         public static void TransactionCleanupTest(string connectionString)
         {

diff --git a/...crosoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderCancellationTest.cs b/...crosoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderCancellationTest.cs
@@ -14,9 +14,10 @@ public class DataReaderCancellationTest
         /// <summary>
         /// Test ensures cancellation token is registered before ReadAsync starts processing results from TDS Stream,
         /// such that when Cancel is triggered, the token is capable of canceling reading further results.
+        /// Synapse: Incompatible query. 
         /// </summary>
         /// <returns>Async Task</returns>
-        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         public static async Task CancellationTokenIsRespected_ReadAsync()
         {
             const string longRunningQuery = @"
@@ -49,9 +50,10 @@ await Assert.ThrowsAsync<TaskCanceledException>(async () =>
         /// <summary>
         /// Test ensures cancellation token is registered before ReadAsync starts processing results from TDS Stream,
         /// such that when Cancel is triggered, the token is capable of canceling reading further results.
+        /// Synapse: Incompatible query & Parallel query execution on the same connection is not supported.
         /// </summary>
         /// <returns>Async Task</returns>
-        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         public static async Task CancelledCancellationTokenIsRespected_ReadAsync()
         {
             const string longRunningQuery = @"

diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderStreamsTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderStreamsTest.cs
@@ -153,7 +153,8 @@ public static async Task GetFieldValueAsync_Char_OfTextReader(CommandBehavior be
             Assert.Equal(originalText, outputText);
         }
 
-        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
+        // Synapse: Cannot find data type 'XML'.
+        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         [MemberData(nameof(GetCommandBehavioursAndIsAsync))]
         public static async void GetFieldValue_OfXmlReader(CommandBehavior behavior, bool isExecuteAsync)
         {

diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSTest/MARSTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/MARSTest/MARSTest.cs
@@ -162,8 +162,8 @@ public static void MARSSyncTimeoutTest()
             }
         }
 #endif
-
-        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
+        // Synapse: Parallel query execution on the same connection is not supported.
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
         public static async Task MARSAsyncBusyReaderTest()
         {
             using SqlConnection con = new(_connStr);