Dispose Glfw/Sdl When Checking if Applicable (#2352)

* Dispose Glfw when Checking if Applicable * Dispose Sdl when Checking if Applicable
dotnet · Nov 11, 2024 · 544b647 · 544b647
1 parent d2871a6
commit 544b647
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Windowing/Silk.NET.Windowing.Glfw/GlfwPlatform.cs b/src/Windowing/Silk.NET.Windowing.Glfw/GlfwPlatform.cs
@@ -23,9 +23,10 @@ internal class GlfwPlatform : IWindowPlatform
         (
             () =>
             {
+                GLFW.Glfw? api = null;
                 try
                 {
-                    GLFW.Glfw.GetApi(); // activate the class so we can determine if we can activate the class
+                    api = GLFW.Glfw.GetApi(); // activate the class so we can determine if we can activate the class
                 }
                 catch (Exception ex)
                 {
@@ -34,6 +35,10 @@ internal class GlfwPlatform : IWindowPlatform
 #endif
                     return false;
                 }
+                finally
+                {
+                    api?.Dispose();
+                }
 
                 return true;
             }

diff --git a/src/Windowing/Silk.NET.Windowing.Sdl/SdlPlatform.cs b/src/Windowing/Silk.NET.Windowing.Sdl/SdlPlatform.cs
@@ -34,9 +34,10 @@ public static SdlPlatform GetOrRegister()
         (
             () =>
             {
+                SDL.Sdl? api = null;
                 try
                 {
-                    SDL.Sdl.GetApi();
+                    api = SDL.Sdl.GetApi();
                 }
                 catch (Exception ex)
                 {
@@ -45,6 +46,10 @@ public static SdlPlatform GetOrRegister()
 #endif
                     return false;
                 }
+                finally
+                {
+                    api?.Dispose();
+                }
 
                 return true;
             }