Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string for default Project Description #2373

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

zahalzel
Copy link
Contributor

@zahalzel zahalzel commented Apr 11, 2023

  • Fixes the string comparison for the project description, so that the default project description is set correctly.
  • In the MVC Web App code modifier config PR, I had deleted the MatchesForProjectType entry for both the Views folder and for Startup.cs from the dotnet-webapp project description
    -- We do not want the Views folder to set "Web app" because it should set MVC web app
    -- But we do want the Startup.cs check, for .NET Framework projects, so I'm adding that back in

related bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1798608

@zahalzel zahalzel requested a review from vijayrkn April 11, 2023 17:47
@zahalzel zahalzel force-pushed the dev/zahalzel/projectDescriptionReaderBug branch from d20de66 to 5db59ae Compare April 11, 2023 19:38
@zahalzel zahalzel merged commit 71bc818 into main Apr 12, 2023
@zahalzel zahalzel deleted the dev/zahalzel/projectDescriptionReaderBug branch April 12, 2023 18:42
zahalzel added a commit that referenced this pull request May 12, 2023
* Fix string for default Project Description

* Add back check for Startup.cs, for .NET Framework projects
zahalzel added a commit that referenced this pull request May 12, 2023
* Fix string for default Project Description

* Add back check for Startup.cs, for .NET Framework projects
zahalzel added a commit that referenced this pull request May 15, 2023
* Fix string for default Project Description

* Add back check for Startup.cs, for .NET Framework projects
deepchoudhery pushed a commit that referenced this pull request May 15, 2023
* Fix string for default Project Description (#2373)

* Fix string for default Project Description

* Add back check for Startup.cs, for .NET Framework projects

* Add instance parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants