Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-msidentity 2.0.1 servicing update #2197

Merged
merged 6 commits into from
Jan 6, 2023

Conversation

deepchoudhery
Copy link
Member

Cherry-picked #2129 , #2144 , #2149, #2181, #2189 (when it goes in)

@deepchoudhery deepchoudhery requested a review from zahalzel January 4, 2023 22:03
Copy link
Contributor

@zahalzel zahalzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

* Refactor console logger

* Exit environment after logging failure

* Add try/catch to app registration creation

* Refactor LogFailure to LogFailureAndExit
@deepchoudhery deepchoudhery merged commit c2dc990 into release/7.0 Jan 6, 2023
@deepchoudhery deepchoudhery deleted the dev/decho/msidentity-servicings branch January 6, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants