optional ThisAssembly generation

[japj]

Is it possible to (optionally) turn off the generation of the ThisAssembly class?

We had a situation where we hit an issue in combination with Fakes generation that took me a while to figure out. (this was eventually solved by adding <Remove TypeName="ThisAssembly"/> in the fakes config).

However, I am not sure if anyone has experienced issues where another library actually generates ThisAssembly content that would conflict with this library.
In that case they would also benefit from a 'switch' to turn it off.

[AArnott]

I would accept a PR for this. Here's a mini-spec of how I would want it:

An msbuild property that turns it off. It should be called GenerateThisAssemblyClass, and passed into the AssemblyVersionInfo task. It should have a default value of true, set either in a (new) .props file or at the top of the .targets file, conditional on it not already having been set.

[AArnott]

Closing due to a workaround being available or lack of popular demand. This allows us to better focus on high impact issues. If you feel this is blocking you, you may add a comment here to explain why this should be prioritized.

Thank you for your understanding.

[AArnott]

Oops. This actually did get fixed in #472

[maniglia]

I would like to use this feature to suppress ThisAssembly class generation, how can I do?
If I enter this: <NBGV_EmitThisAssemblyClass>false</NBGV_EmitThisAssemblyClass> in my project, is that enough?

[AArnott]

Yes