Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcoreapp3.0 target for nbgv #277

Closed
clairernovotny opened this issue Dec 15, 2018 · 3 comments · Fixed by #326
Closed

Add netcoreapp3.0 target for nbgv #277

clairernovotny opened this issue Dec 15, 2018 · 3 comments · Fixed by #326
Milestone

Comments

@clairernovotny
Copy link
Member

.NET Core global tools will auto roll-forward to the next minor. So for people that only have netcoreapp2.2, the current netcoreapp2.1 target will work just fine. Major versions do not roll forward, so if a user only has netcoreapp3.0, then the tool will fail.

The solution is to either have users with both a .NET Core 2.x SDK and a 3.x SDK or to have tools multi-target. For ease of users, I'm recommending all .NET Core global tools add a netcoreapp3.0 target.

/cc @KathleenDollard

@clairernovotny
Copy link
Member Author

I can add this as a PR

@KathleenDollard
Copy link

KathleenDollard commented Dec 17, 2018 via email

@ctaggart
Copy link
Contributor

It would be nice to be able to do this:

docker run --rm -it mcr.microsoft.com/dotnet/core/sdk:3.0.100-preview3-alpine3.9 sh
dotnet tool install -g nbgv
$HOME/.dotnet/tools/nbgv get-version

But it does not currently work:

/ # dotnet tool install -g nbgv
Tools directory '/root/.dotnet/tools' is not currently on the PATH environment variable.
If you are using bash, you can add it to your profile by running the following command:

cat << \EOF >> ~/.bash_profile
# Add .NET Core SDK tools
export PATH="$PATH:/root/.dotnet/tools"
EOF

You can add it to the current session by running the following command:

export PATH="$PATH:/root/.dotnet/tools"

You can invoke the tool using the following command: nbgv
Tool 'nbgv' (version '2.3.138') was successfully installed.
/ # $HOME/.dotnet/tools/nbgv get-version
It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
  - Check application dependencies and target a framework version installed at:
      /usr/share/dotnet
  - The .NET Core Runtime and SDK can be installed from:
      https://aka.ms/dotnet-download
  - The following versions are installed:
      3.0.0-preview3-27503-5 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  - Installing .NET Core prerequisites might help resolve this problem:
      https://go.microsoft.com/fwlink/?linkid=2063370

AArnott pushed a commit that referenced this issue Aug 8, 2024
Bumps [powershell](https://github.com/PowerShell/PowerShell) from 7.4.3 to 7.4.4.
- [Release notes](https://github.com/PowerShell/PowerShell/releases)
- [Commits](PowerShell/PowerShell@v7.4.3...v7.4.4)

---
updated-dependencies:
- dependency-name: powershell
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants