Fix console errors #457
Merged
Fix console errors #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
commented
Dec 9, 2020
tlmii
added a commit
to tlmii/HttpRepl
that referenced
this pull request
Jan 4, 2021
* Fix console errors * Tweaking test code
tlmii
added a commit
that referenced
this pull request
Jan 4, 2021
This was referenced Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443.
See #443 (comment) for details on the specific problems in HttpRepl and microsoft/terminal#8312 for some background on why the issues show up differently (or not at all) in different terminals.
Essentially, HttpRepl tied the caret position on the input buffer to the caret position of the console window in a way that causes problems in virtual terminals (e.g. Windows Terminal). Not all terminals were impacted the same way, though all variants other than vanilla cmd.exe had problems.
To fix this, we "disconnect" the cursor position in the console window from the cursor position in the input buffer, but still move them together when appropriate. The concept of the
CaretPositionis moved from the ConsoleManager to the InputManager (since it tracks with the input buffer more directly than it does with the console cursor) and the CaretUpdateScope concept is removed completely.One thing we are lacking, that this PR does not address, is the ability to actually drive the console output of various consoles to ensure the input buffer caret and the console caret track properly when they're supposed to.